Strict null check code action tests

mjbvz · mjbvz · commit d85a16f2e435 · 2018-12-17T17:16:43.000-08:00
diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json
@@ -190,6 +190,8 @@
 		"./vs/editor/contrib/codeAction/codeActionTrigger.ts",
 		"./vs/editor/contrib/codeAction/codeActionWidget.ts",
 		"./vs/editor/contrib/codeAction/lightBulbWidget.ts",
+		"./vs/editor/contrib/codeAction/test/codeAction.test.ts",
+		"./vs/editor/contrib/codeAction/test/codeActionModel.test.ts",
 		"./vs/editor/contrib/codelens/codelens.ts",
 		"./vs/editor/contrib/codelens/codelensController.ts",
 		"./vs/editor/contrib/codelens/codelensWidget.ts",
diff --git a/src/vs/editor/contrib/codeAction/test/codeAction.test.ts b/src/vs/editor/contrib/codeAction/test/codeAction.test.ts
@@ -156,7 +156,7 @@ suite('CodeAction', () => {
 		const provider = new class implements CodeActionProvider {
 			provideCodeActions(_model: any, _range: Range, context: CodeActionContext, _token: any): CodeAction[] {
 				return [
-					{ title: context.only, kind: context.only }
+					{ title: context.only || '', kind: context.only }
 				];
 			}
 		};
diff --git a/src/vs/editor/contrib/codeAction/test/codeActionModel.test.ts b/src/vs/editor/contrib/codeAction/test/codeActionModel.test.ts
@@ -51,7 +51,7 @@ suite('CodeAction', () => {
 			assert.equal(e.trigger.type, 'auto');
 			assert.ok(e.actions);
 
-			e.actions.then(fixes => {
+			e.actions!.then(fixes => {
 				oracle.dispose();
 				assert.equal(fixes.length, 1);
 				done();
@@ -88,7 +88,7 @@ suite('CodeAction', () => {
 			const oracle = new CodeActionOracle(editor, markerService, e => {
 				assert.equal(e.trigger.type, 'auto');
 				assert.ok(e.actions);
-				e.actions.then(fixes => {
+				e.actions!.then(fixes => {
 					oracle.dispose();
 					assert.equal(fixes.length, 1);
 					resolve(undefined);
@@ -107,7 +107,7 @@ suite('CodeAction', () => {
 		});
 		disposables.push(reg);
 
-		editor.getModel().setValue('// @ts-check\n2\ncon\n');
+		editor.getModel()!.setValue('// @ts-check\n2\ncon\n');
 
 		markerService.changeOne('fake', uri, [{
 			startLineNumber: 3, startColumn: 1, endLineNumber: 3, endColumn: 4,
@@ -130,7 +130,7 @@ suite('CodeAction', () => {
 				assert.deepEqual(e.position, { lineNumber: 3, column: 1 });
 
 				oracle.dispose();
-				resolve(null);
+				resolve(void 0);
 			}, 5);
 
 			editor.setSelection({ startLineNumber: 1, startColumn: 1, endLineNumber: 4, endColumn: 1 });

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ suite('CodeAction', () => {`
`156`	`156`	`const provider = new class implements CodeActionProvider {`
`157`	`157`	`provideCodeActions(_model: any, _range: Range, context: CodeActionContext, _token: any): CodeAction[] {`
`158`	`158`	`return [`
`159`		`- { title: context.only, kind: context.only }`
	`159`	`+ { title: context.only \|\| '', kind: context.only }`
`160`	`160`	`];`
`161`	`161`	`}`
`162`	`162`	`};`