fixes issue where hidden element orientation is not updated when hidden

sbatten · sbatten · commit d5af2a20fc70 · 2019-01-29T22:37:50.000-08:00
diff --git a/src/vs/base/browser/ui/grid/grid.ts b/src/vs/base/browser/ui/grid/grid.ts
@@ -698,13 +698,19 @@ export class View implements IView {
 	}
 
 	layout(width: number, height: number, orientation: Orientation): void {
-		if (!this.visible) {
+		if (!this.visible && this.orientation === orientation) {
 			return;
 		}
 
-		this.view.layout(width, height, orientation);
-		this.width = width;
-		this.height = height;
+
+
+		if (this.visible) {
+			this.view.layout(width, height, orientation);
+
+			this.width = width;
+			this.height = height;
+		}
+
 		this.orientation = orientation;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -698,13 +698,19 @@ export class View implements IView {`
`698`	`698`	`}`
`699`	`699`
`700`	`700`	`layout(width: number, height: number, orientation: Orientation): void {`
`701`		`- if (!this.visible) {`
	`701`	`+ if (!this.visible && this.orientation === orientation) {`
`702`	`702`	`return;`
`703`	`703`	`}`
`704`	`704`
`705`		`- this.view.layout(width, height, orientation);`
`706`		`- this.width = width;`
`707`		`- this.height = height;`
	`705`	`+`
	`706`	`+`
	`707`	`+ if (this.visible) {`
	`708`	`+ this.view.layout(width, height, orientation);`
	`709`	`+`
	`710`	`+ this.width = width;`
	`711`	`+ this.height = height;`
	`712`	`+ }`
	`713`	`+`
`708`	`714`	`this.orientation = orientation;`
`709`	`715`	`}`
`710`	`716`	`}`