don't forget return statements, microsoft#23332

jrieken · jrieken · commit d4a9c3037857 · 2017-03-28T09:13:23.000+02:00
diff --git a/src/vs/base/common/filters.ts b/src/vs/base/common/filters.ts
@@ -602,7 +602,7 @@ function findAllMatches(patternLen: number, patternPos: number, wordPos: number,
 			matches.unshift(wordPos);
 
 		} else {
-			// undefined
+			return undefined;
 		}
 	}
 
diff --git a/src/vs/base/test/common/filters.test.ts b/src/vs/base/test/common/filters.test.ts
@@ -214,6 +214,9 @@ suite('Filters', () => {
 		assertMatches('WordCla', 'WordCharacterClassifier', '^W^o^r^d^CharacterC^l^assifier', fuzzyScore);
 		assertMatches('WordCCla', 'WordCharacterClassifier', '^W^o^r^d^Character^C^l^assifier', fuzzyScore);
 	});
+	test('fuzzyScore, #23332', function () {
+		assertMatches('dete', '"editor.quickSuggestionsDelay"', undefined, fuzzyScore);
+	});
 
 	test('fuzzyScore', function () {
 		assertMatches('ab', 'abA', '^a^bA', fuzzyScore);

Original file line number	Diff line number	Diff line change
`@@ -602,7 +602,7 @@ function findAllMatches(patternLen: number, patternPos: number, wordPos: number,`
`602`	`602`	`matches.unshift(wordPos);`
`603`	`603`
`604`	`604`	`} else {`
`605`		`- // undefined`
	`605`	`+ return undefined;`
`606`	`606`	`}`
`607`	`607`	`}`
`608`	`608`