propagate editor part visibility (fix microsoft#68320)

Benjamin Pasero · Benjamin Pasero · commit d3066ce7c50c · 2019-08-08T08:27:19.000+02:00
diff --git a/src/vs/workbench/browser/parts/editor/editor.ts b/src/vs/workbench/browser/parts/editor/editor.ts
@@ -81,12 +81,15 @@ export interface IEditorOpeningEvent extends IEditorIdentifier {
 }
 
 export interface IEditorGroupsAccessor {
+
 	readonly groups: IEditorGroupView[];
 	readonly activeGroup: IEditorGroupView;
 
 	readonly partOptions: IEditorPartOptions;
 	readonly onDidEditorPartOptionsChange: Event<IEditorPartOptionsChangeEvent>;
 
+	readonly onDidVisibilityChange: Event<boolean>;
+
 	getGroup(identifier: GroupIdentifier): IEditorGroupView | undefined;
 	getGroups(order: GroupsOrder): IEditorGroupView[];
 
diff --git a/src/vs/workbench/browser/parts/editor/editorControl.ts b/src/vs/workbench/browser/parts/editor/editorControl.ts
@@ -221,6 +221,12 @@ export class EditorControl extends Disposable {
 		}
 	}
 
+	setVisible(visible: boolean): void {
+		if (this._activeControl) {
+			this._activeControl.setVisible(visible, this.groupView);
+		}
+	}
+
 	layout(dimension: Dimension): void {
 		this.dimension = dimension;
 
diff --git a/src/vs/workbench/browser/parts/editor/editorGroupView.ts b/src/vs/workbench/browser/parts/editor/editorGroupView.ts
@@ -468,6 +468,9 @@ export class EditorGroupView extends Themable implements IEditorGroupView {
 
 		// Option Changes
 		this._register(this.accessor.onDidEditorPartOptionsChange(e => this.onDidEditorPartOptionsChange(e)));
+
+		// Visibility
+		this._register(this.accessor.onDidVisibilityChange(e => this.onDidVisibilityChange(e)));
 	}
 
 	private onDidEditorPin(editor: EditorInput): void {
@@ -635,6 +638,12 @@ export class EditorGroupView extends Themable implements IEditorGroupView {
 		this._onDidGroupChange.fire({ kind: GroupChangeKind.EDITOR_LABEL, editor });
 	}
 
+	private onDidVisibilityChange(visible: boolean): void {
+
+		// Forward to editor control
+		this.editorControl.setVisible(visible);
+	}
+
 	//#endregion
 
 	//region IEditorGroupView

Original file line number	Diff line number	Diff line change
`@@ -221,6 +221,12 @@ export class EditorControl extends Disposable {`
`221`	`221`	`}`
`222`	`222`	`}`
`223`	`223`
	`224`	`+ setVisible(visible: boolean): void {`
	`225`	`+ if (this._activeControl) {`
	`226`	`+ this._activeControl.setVisible(visible, this.groupView);`
	`227`	`+ }`
	`228`	`+ }`
	`229`	`+`
`224`	`230`	`layout(dimension: Dimension): void {`
`225`	`231`	`this.dimension = dimension;`
`226`	`232`