Remove windows-process-tree types if they get installed

mjbvz · mjbvz · commit cf4e17cd4b51 · 2018-11-08T17:49:45.000-08:00
These typings cause duplicate identifier errors on windows tsc builds
diff --git a/build/npm/postinstall.js b/build/npm/postinstall.js
@@ -60,4 +60,11 @@ runtime "${runtime}"`;
 
 yarnInstall(`build`); // node modules required for build
 yarnInstall('test/smoke'); // node modules required for smoketest
-yarnInstallBuildDependencies(); // node modules for watching, specific to host node version, not electron
+yarnInstallBuildDependencies(); // node modules for watching, specific to host node version, not electron
+
+// Remove the windows process tree typings as this causes duplicate identifier errors in tsc builds
+const processTreeDts = path.join('node_modules', 'windows-process-tree', 'typings', 'windows-process-tree.d.ts');
+if (fs.existsSync(processTreeDts)) {
+	console.log('Removing windows-process-tree.d.ts');
+	fs.unlinkSync(processTreeDts);
+}
diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json
@@ -701,7 +701,6 @@
 		"./vs/code/electron-browser/processExplorer/processExplorerMain.ts"
 	],
 	"exclude": [
-		"./typings/require-monaco.d.ts",
-		"./typings/windows-process-tree.d.ts"
+		"./typings/require-monaco.d.ts"
 	]
 }

Original file line number	Diff line number	Diff line change
`@@ -701,7 +701,6 @@`
`701`	`701`	`"./vs/code/electron-browser/processExplorer/processExplorerMain.ts"`
`702`	`702`	`],`
`703`	`703`	`"exclude": [`
`704`		`- "./typings/require-monaco.d.ts",`
`705`		`- "./typings/windows-process-tree.d.ts"`
	`704`	`+ "./typings/require-monaco.d.ts"`
`706`	`705`	`]`
`707`	`706`	`}`