scm: remove commit method from api

joaomoreno · joaomoreno · commit ced55cc29171 · 2017-01-31T15:36:44.000+01:00
diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts
@@ -135,7 +135,6 @@ declare module 'vscode' {
 		readonly onDidChange: Event<SCMResourceGroup[]>;
 		getOriginalResource?(uri: Uri, token: CancellationToken): ProviderResult<Uri>;
 
-		commit?(message: string, token: CancellationToken): ProviderResult<void>;
 		open?(resource: SCMResource, token: CancellationToken): ProviderResult<void>;
 		drag?(resource: SCMResource, resourceGroup: SCMResourceGroup, token: CancellationToken): ProviderResult<void>;
 	}
diff --git a/src/vs/workbench/api/node/extHost.protocol.ts b/src/vs/workbench/api/node/extHost.protocol.ts
@@ -242,7 +242,6 @@ export abstract class MainProcessExtensionServiceShape {
 
 export interface SCMProviderFeatures {
 	label: string;
-	supportsCommit: boolean;
 	supportsOpen: boolean;
 	supportsDrag: boolean;
 	supportsOriginalResource: boolean;
@@ -390,7 +389,6 @@ export abstract class ExtHostTerminalServiceShape {
 }
 
 export abstract class ExtHostSCMShape {
-	$commit(id: string, message: string): TPromise<void> { throw ni(); }
 	$open(id: string, resourceGroupId: string, uri: string): TPromise<void> { throw ni(); }
 	$drag(id: string, fromResourceGroupId: string, fromUri: string, toResourceGroupId: string): TPromise<void> { throw ni(); }
 	$getOriginalResource(id: string, uri: URI): TPromise<URI> { throw ni(); }
diff --git a/src/vs/workbench/api/node/extHostSCM.ts b/src/vs/workbench/api/node/extHostSCM.ts
@@ -113,7 +113,6 @@ export class ExtHostSCM {
 
 		this._proxy.$register(providerId, {
 			label: provider.label,
-			supportsCommit: !!provider.commit,
 			supportsOpen: !!provider.open,
 			supportsDrag: !!provider.drag,
 			supportsOriginalResource: !!provider.getOriginalResource
@@ -162,16 +161,6 @@ export class ExtHostSCM {
 		});
 	}
 
-	$commit(providerId: string, message: string): TPromise<void> {
-		const provider = this._providers[providerId];
-
-		if (!provider) {
-			return TPromise.as(null);
-		}
-
-		return asWinJsPromise(token => provider.commit(message, token));
-	}
-
 	$open(providerId: string, resourceGroupId: string, uri: string): TPromise<void> {
 		const provider = this._providers[providerId];
 
diff --git a/src/vs/workbench/api/node/mainThreadSCM.ts b/src/vs/workbench/api/node/mainThreadSCM.ts
@@ -38,14 +38,6 @@ class MainThreadSCMProvider implements ISCMProvider {
 		this.disposables.push(scmService.registerSCMProvider(this));
 	}
 
-	commit(message: string): TPromise<void> {
-		if (!this.features.supportsCommit) {
-			return TPromise.as(null);
-		}
-
-		return this.proxy.$commit(this.id, message);
-	}
-
 	open(resource: ISCMResource): TPromise<void> {
 		if (!this.features.supportsOpen) {
 			return TPromise.as(null);
diff --git a/src/vs/workbench/parts/git/browser/gitScm.ts b/src/vs/workbench/parts/git/browser/gitScm.ts
@@ -44,10 +44,6 @@ export class GitSCMProvider implements IWorkbenchContribution, ISCMProvider, ITe
 		return 'git.contentprovider';
 	}
 
-	commit(message: string): TPromise<void> {
-		return TPromise.wrapError<void>('not implemented');
-	}
-
 	open(uri: ISCMResource): TPromise<void> {
 		return TPromise.wrapError<void>('not implemented');
 	}
diff --git a/src/vs/workbench/services/scm/common/scm.ts b/src/vs/workbench/services/scm/common/scm.ts
@@ -41,7 +41,6 @@ export interface ISCMProvider extends IDisposable {
 	readonly resources: ISCMResourceGroup[];
 	readonly onDidChange: Event<ISCMResourceGroup[]>;
 
-	commit(message: string): TPromise<void>;
 	open(uri: ISCMResource): TPromise<void>;
 	drag(from: ISCMResource, to: ISCMResourceGroup): TPromise<void>;
 	getOriginalResource(uri: URI): TPromise<URI>;

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,6 @@ declare module 'vscode' {`
`135`	`135`	`readonly onDidChange: Event<SCMResourceGroup[]>;`
`136`	`136`	`getOriginalResource?(uri: Uri, token: CancellationToken): ProviderResult<Uri>;`
`137`	`137`
`138`		`- commit?(message: string, token: CancellationToken): ProviderResult<void>;`
`139`	`138`	`open?(resource: SCMResource, token: CancellationToken): ProviderResult<void>;`
`140`	`139`	`drag?(resource: SCMResource, resourceGroup: SCMResourceGroup, token: CancellationToken): ProviderResult<void>;`
`141`	`140`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,10 +44,6 @@ export class GitSCMProvider implements IWorkbenchContribution, ISCMProvider, ITe`
`44`	`44`	`return 'git.contentprovider';`
`45`	`45`	`}`
`46`	`46`
`47`		`- commit(message: string): TPromise<void> {`
`48`		`- return TPromise.wrapError<void>('not implemented');`
`49`		`- }`
`50`		`-`
`51`	`47`	`open(uri: ISCMResource): TPromise<void> {`
`52`	`48`	`return TPromise.wrapError<void>('not implemented');`
`53`	`49`	`}`