Do not change extensionDevelopmentLocation letter casing

isidorn · isidorn · commit cec1733b008b · 2018-09-26T11:14:49.000+02:00
fixes microsoft#58388
diff --git a/src/vs/base/common/resources.ts b/src/vs/base/common/resources.ts
@@ -124,7 +124,7 @@ export function normalizePath(resource: URI): URI {
  * Returns the fsPath of an URI where the drive letter is not normalized.
  * See #56403.
  */
-function fsPath(uri: URI): string {
+export function fsPath(uri: URI): string {
 	let value: string;
 	if (uri.authority && uri.path.length > 1 && uri.scheme === 'file') {
 		// unc path: file://shares/c$/far/boo
@@ -186,4 +186,3 @@ export function isMalformedFileUri(candidate: URI): URI | undefined {
 	}
 	return void 0;
 }
-
diff --git a/src/vs/workbench/services/extensions/electron-browser/extensionService.ts b/src/vs/workbench/services/extensions/electron-browser/extensionService.ts
@@ -44,7 +44,7 @@ import { INotificationService, Severity, INotificationHandle } from 'vs/platform
 import { isFalsyOrEmpty } from 'vs/base/common/arrays';
 import { Schemas } from 'vs/base/common/network';
 import { getPathFromAmdModule } from 'vs/base/common/amd';
-import { isEqualOrParent } from 'vs/base/common/resources';
+import { isEqualOrParent, fsPath } from 'vs/base/common/resources';
 import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
 import { RuntimeExtensionsInput } from 'vs/workbench/services/extensions/electron-browser/runtimeExtensionsInput';
 
@@ -959,7 +959,7 @@ export class ExtensionService extends Disposable implements IExtensionService {
 			let developedExtensions = TPromise.as([]);
 			if (environmentService.isExtensionDevelopment && environmentService.extensionDevelopmentLocationURI.scheme === Schemas.file) {
 				developedExtensions = ExtensionScanner.scanOneOrMultipleExtensions(
-					new ExtensionScannerInput(version, commit, locale, devMode, environmentService.extensionDevelopmentLocationURI.fsPath, false, true, translations), log
+					new ExtensionScannerInput(version, commit, locale, devMode, fsPath(environmentService.extensionDevelopmentLocationURI), false, true, translations), log
 				);
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ export function normalizePath(resource: URI): URI {`
`124`	`124`	`* Returns the fsPath of an URI where the drive letter is not normalized.`
`125`	`125`	`* See #56403.`
`126`	`126`	`*/`
`127`		`-function fsPath(uri: URI): string {`
	`127`	`+export function fsPath(uri: URI): string {`
`128`	`128`	`let value: string;`
`129`	`129`	`if (uri.authority && uri.path.length > 1 && uri.scheme === 'file') {`
`130`	`130`	`// unc path: file://shares/c$/far/boo`
`@@ -186,4 +186,3 @@ export function isMalformedFileUri(candidate: URI): URI \| undefined {`
`186`	`186`	`}`
`187`	`187`	`return void 0;`
`188`	`188`	`}`
`189`		`-`