fix notebook integration test

rebornix · rebornix · commit cea1d2f91f2b · 2020-04-24T13:04:14.000-07:00
diff --git a/extensions/vscode-notebook-tests/src/notebook.test.ts b/extensions/vscode-notebook-tests/src/notebook.test.ts
@@ -46,7 +46,7 @@ suite('notebook workflow', () => {
 	});
 
 	test('notebook cell actions', async function () {
-		const resource = vscode.Uri.parse(join(vscode.workspace.rootPath || '', './second.vsctestnb'));
+		const resource = vscode.Uri.parse(join(vscode.workspace.rootPath || '', './first.vsctestnb'));
 		await vscode.commands.executeCommand('vscode.openWith', resource, 'notebookCoreTest');
 
 		await waitFor(500);
diff --git a/extensions/vscode-notebook-tests/test/second.vsctestnb b/extensions/vscode-notebook-tests/test/second.vsctestnb
diff --git a/src/vs/workbench/contrib/notebook/browser/notebookEditor.ts b/src/vs/workbench/contrib/notebook/browser/notebookEditor.ts
@@ -513,10 +513,10 @@ export class NotebookEditor extends BaseEditor implements INotebookEditor {
 		this.list!.layout();
 
 		// restore list state at last, it must be after list layout
-		this.restoreTextEditorViewState(viewState);
+		this.restoreListViewState(viewState);
 	}
 
-	private restoreTextEditorViewState(viewState: INotebookEditorViewState | undefined): void {
+	private restoreListViewState(viewState: INotebookEditorViewState | undefined): void {
 		if (viewState?.scrollPosition !== undefined) {
 			this.list!.scrollTop = viewState!.scrollPosition.top;
 			this.list!.scrollLeft = viewState!.scrollPosition.left;
@@ -526,8 +526,12 @@ export class NotebookEditor extends BaseEditor implements INotebookEditor {
 		}
 
 		const focusIdx = typeof viewState?.focus === 'number' ? viewState.focus : 0;
-		this.list!.setFocus([focusIdx]);
-		this.list!.setSelection([focusIdx]);
+		if (focusIdx < this.list!.length) {
+			this.list!.setFocus([focusIdx]);
+			this.list!.setSelection([focusIdx]);
+		} else if (this.list!.length > 0) {
+			this.list!.setFocus([0]);
+		}
 
 		if (viewState?.editorFocused) {
 			this.list?.focusView();
