bugfix - typescript code completion doesn't recognize property modifiers when more than one exists (microsoft#94165)

Git-Lior · web-flow · commit ce57f8ad58fd · 2020-04-07T13:22:28.000-07:00
* fix microsoft/TypeScript#37117 - code completion in typescript fails to recognize property modifiers * split kindModifiers by comma or spaces
diff --git a/extensions/typescript-language-features/src/features/completions.ts b/extensions/typescript-language-features/src/features/completions.ts
@@ -97,7 +97,7 @@ class MyCompletionItem extends vscode.CompletionItem {
 		}
 
 		if (tsEntry.kindModifiers) {
-			const kindModifiers = new Set(tsEntry.kindModifiers.split(/\s+/g));
+			const kindModifiers = new Set(tsEntry.kindModifiers.split(/,|\s+/g));
 			if (kindModifiers.has(PConst.KindModifiers.optional)) {
 				if (!this.insertText) {
 					this.insertText = this.label;

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ class MyCompletionItem extends vscode.CompletionItem {`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`if (tsEntry.kindModifiers) {`
`100`		`- const kindModifiers = new Set(tsEntry.kindModifiers.split(/\s+/g));`
	`100`	`+ const kindModifiers = new Set(tsEntry.kindModifiers.split(/,\|\s+/g));`
`101`	`101`	`if (kindModifiers.has(PConst.KindModifiers.optional)) {`
`102`	`102`	`if (!this.insertText) {`
`103`	`103`	`this.insertText = this.label;`