Use set to check configuredUIExtensions

mjbvz · mjbvz · commit cd8260bc94d3 · 2019-04-15T17:12:34.000-07:00
diff --git a/src/vs/platform/extensions/node/extensionsUtil.ts b/src/vs/platform/extensions/node/extensionsUtil.ts
@@ -11,14 +11,12 @@ import product from 'vs/platform/product/node/product';
 
 export function isUIExtension(manifest: IExtensionManifest, uiContributions: string[], configurationService: IConfigurationService): boolean {
 	const extensionId = getGalleryExtensionId(manifest.publisher, manifest.name);
-	const configuredUIExtensions = configurationService.getValue<string[]>('_workbench.uiExtensions') || [];
-	if (configuredUIExtensions.length) {
-		if (configuredUIExtensions.indexOf(extensionId) !== -1) {
-			return true;
-		}
-		if (configuredUIExtensions.indexOf(`-${extensionId}`) !== -1) {
-			return false;
-		}
+	const configuredUIExtensions = new Set(configurationService.getValue<string[]>('_workbench.uiExtensions') || []);
+	if (configuredUIExtensions.has(extensionId)) {
+		return true;
+	}
+	if (configuredUIExtensions.has(`-${extensionId}`)) {
+		return false;
 	}
 	switch (manifest.extensionKind) {
 		case 'ui': return true;
