Skip to content

Commit cced925

Browse files
committed
1 parent b36f52e commit cced925

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

src/vs/workbench/contrib/extensions/browser/extensionsViewlet.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ import { IThemeService } from 'vs/platform/theme/common/themeService';
3636
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
3737
import { IViewsRegistry, IViewDescriptor, Extensions, ViewContainer, IViewDescriptorService, IAddedViewDescriptorRef } from 'vs/workbench/common/views';
3838
import { IStorageService, StorageScope } from 'vs/platform/storage/common/storage';
39-
import { IWorkspaceContextService, WorkbenchState } from 'vs/platform/workspace/common/workspace';
39+
import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
4040
import { IContextKeyService, ContextKeyExpr, RawContextKey, IContextKey } from 'vs/platform/contextkey/common/contextkey';
4141
import { IContextMenuService } from 'vs/platform/contextview/browser/contextView';
4242
import { getMaliciousExtensionsSet } from 'vs/platform/extensionManagement/common/extensionManagementUtil';
@@ -59,8 +59,8 @@ import { DragAndDropObserver } from 'vs/workbench/browser/dnd';
5959
import { URI } from 'vs/base/common/uri';
6060
import { SIDE_BAR_DRAG_AND_DROP_BACKGROUND } from 'vs/workbench/common/theme';
6161
import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService';
62+
import { WorkbenchStateContext } from 'vs/workbench/browser/contextkeys';
6263

63-
const NonEmptyWorkspaceContext = new RawContextKey<boolean>('nonEmptyWorkspace', false);
6464
const DefaultViewsContext = new RawContextKey<boolean>('defaultExtensionViews', true);
6565
const SearchMarketplaceExtensionsContext = new RawContextKey<boolean>('searchMarketplaceExtensions', false);
6666
const SearchIntalledExtensionsContext = new RawContextKey<boolean>('searchInstalledExtensions', false);
@@ -280,7 +280,7 @@ export class ExtensionsViewletViewsContribution implements IWorkbenchContributio
280280
id: 'workbench.views.extensions.workspaceRecommendations',
281281
name: localize('workspaceRecommendedExtensions', "Workspace Recommendations"),
282282
ctorDescriptor: new SyncDescriptor(WorkspaceRecommendedExtensionsView),
283-
when: ContextKeyExpr.and(ContextKeyExpr.has('recommendedExtensions'), ContextKeyExpr.has('nonEmptyWorkspace')),
283+
when: ContextKeyExpr.and(ContextKeyExpr.has('recommendedExtensions'), WorkbenchStateContext.notEqualsTo('empty')),
284284
order: 1
285285
});
286286

@@ -328,7 +328,6 @@ export class ExtensionsViewPaneContainer extends ViewPaneContainer implements IE
328328

329329
private readonly _onSearchChange: Emitter<string> = this._register(new Emitter<string>());
330330
private readonly onSearchChange: EventOf<string> = this._onSearchChange.event;
331-
private nonEmptyWorkspaceContextKey: IContextKey<boolean>;
332331
private defaultViewsContextKey: IContextKey<boolean>;
333332
private searchMarketplaceExtensionsContextKey: IContextKey<boolean>;
334333
private searchInstalledExtensionsContextKey: IContextKey<boolean>;
@@ -369,7 +368,6 @@ export class ExtensionsViewPaneContainer extends ViewPaneContainer implements IE
369368
super(VIEWLET_ID, { mergeViewWithContainerWhenSingleView: true }, instantiationService, configurationService, layoutService, contextMenuService, telemetryService, extensionService, themeService, storageService, contextService, viewDescriptorService);
370369

371370
this.searchDelayer = new Delayer(500);
372-
this.nonEmptyWorkspaceContextKey = NonEmptyWorkspaceContext.bindTo(contextKeyService);
373371
this.defaultViewsContextKey = DefaultViewsContext.bindTo(contextKeyService);
374372
this.searchMarketplaceExtensionsContextKey = SearchMarketplaceExtensionsContext.bindTo(contextKeyService);
375373
this.searchInstalledExtensionsContextKey = SearchIntalledExtensionsContext.bindTo(contextKeyService);
@@ -612,7 +610,6 @@ export class ExtensionsViewPaneContainer extends ViewPaneContainer implements IE
612610
this.builtInExtensionsContextKey.set(ExtensionsListView.isBuiltInExtensionsQuery(value));
613611
this.recommendedExtensionsContextKey.set(isRecommendedExtensionsQuery);
614612
this.searchMarketplaceExtensionsContextKey.set(!!value && !ExtensionsListView.isLocalExtensionsQuery(value) && !isRecommendedExtensionsQuery);
615-
this.nonEmptyWorkspaceContextKey.set(this.contextService.getWorkbenchState() !== WorkbenchState.EMPTY);
616613
this.defaultViewsContextKey.set(!value);
617614

618615
return this.progress(Promise.all(this.panes.map(view =>

0 commit comments

Comments
 (0)