env - move up logExtensionHostCommunication

Benjamin Pasero · Benjamin Pasero · commit ccbb0da040ff · 2019-10-24T11:18:44.000+02:00
diff --git a/src/vs/platform/environment/common/environment.ts b/src/vs/platform/environment/common/environment.ts
@@ -142,6 +142,7 @@ export interface IEnvironmentService {
 	extensionsPath?: string;
 	extensionDevelopmentLocationURI?: URI[];
 	extensionTestsLocationURI?: URI;
+	logExtensionHostCommunication?: boolean;
 
 	debugExtensionHost: IExtensionHostDebugParams;
 
diff --git a/src/vs/platform/environment/node/environmentService.ts b/src/vs/platform/environment/node/environmentService.ts
@@ -235,6 +235,8 @@ export class EnvironmentService implements IEnvironmentService {
 
 	@memoize
 	get debugExtensionHost(): IExtensionHostDebugParams { return parseExtensionHostPort(this._args, this.isBuilt); }
+	@memoize
+	get logExtensionHostCommunication(): boolean { return !!this.args.logExtensionHostCommunication; }
 
 	get isBuilt(): boolean { return !process.env['VSCODE_DEV']; }
 	get verbose(): boolean { return !!this._args.verbose; }
diff --git a/src/vs/workbench/services/environment/browser/environmentService.ts b/src/vs/workbench/services/environment/browser/environmentService.ts
@@ -230,6 +230,7 @@ export class BrowserWorkbenchEnvironmentService implements IWorkbenchEnvironment
 	machineSettingsHome!: URI;
 	machineSettingsResource!: URI;
 
+	userHome!: string;
 	userDataPath!: string;
 	appRoot!: string;
 	appSettingsHome!: URI;
@@ -245,8 +246,6 @@ export class BrowserWorkbenchEnvironmentService implements IWorkbenchEnvironment
 
 	galleryMachineIdResource?: URI;
 
-	userHome!: string;
-
 	//#endregion
 
 	constructor(readonly options: IBrowserWorkbenchEnvironmentConstructionOptions) { }
diff --git a/src/vs/workbench/services/environment/common/environmentService.ts b/src/vs/workbench/services/environment/common/environmentService.ts
@@ -20,7 +20,6 @@ export interface IWorkbenchEnvironmentService extends IEnvironmentService {
 	readonly options?: IWorkbenchConstructionOptions;
 
 	readonly logFile: URI;
-	readonly logExtensionHostCommunication: boolean;
 
 	readonly webviewExternalEndpoint: string;
 	readonly webviewResourceRoot: string;
diff --git a/src/vs/workbench/services/environment/electron-browser/environmentService.ts b/src/vs/workbench/services/environment/electron-browser/environmentService.ts
@@ -36,9 +36,6 @@ export class NativeWorkbenchEnvironmentService extends EnvironmentService implem
 	@memoize
 	get logFile(): URI { return URI.file(join(this.logsPath, `renderer${this.windowId}.log`)); }
 
-	@memoize
-	get logExtensionHostCommunication(): boolean { return !!this.args.logExtensionHostCommunication; }
-
 	constructor(
 		readonly configuration: IWindowConfiguration,
 		execPath: string,
