fix microsoft#53424 (microsoft#53425)

bpasero · Benjamin Pasero · commit cc2a16494cf1 · 2018-07-02T09:23:21.000+02:00
diff --git a/src/vs/base/browser/ui/grid/gridview.ts b/src/vs/base/browser/ui/grid/gridview.ts
@@ -27,14 +27,6 @@ export interface IView {
 	layout(width: number, height: number): void;
 }
 
-/*
-TODO:
-	- NEW: 	add a color to show a border where the sash is, similar to how other
-			widgets have a color (e.g. Button, with applyStyles). Challenge is that this
-			color has to be applied via JS and not CSS to not apply it to all views
-			NOT CSS
-*/
-
 export function orthogonal(orientation: Orientation): Orientation {
 	return orientation === Orientation.VERTICAL ? Orientation.HORIZONTAL : Orientation.VERTICAL;
 }
diff --git a/src/vs/workbench/browser/parts/editor/editorPart.ts b/src/vs/workbench/browser/parts/editor/editorPart.ts
@@ -35,7 +35,7 @@ import { EditorDropTarget } from 'vs/workbench/browser/parts/editor/editorDropTa
 import { localize } from 'vs/nls';
 import { Color } from 'vs/base/common/color';
 import { CenteredViewLayout } from 'vs/base/browser/ui/centered/centeredViewLayout';
-import { IView } from 'vs/base/browser/ui/grid/gridview';
+import { IView, orthogonal } from 'vs/base/browser/ui/grid/gridview';
 
 interface IEditorPartUIState {
 	serializedGrid: ISerializedGrid;
@@ -414,7 +414,9 @@ export class EditorPart extends Part implements EditorGroupsServiceImpl, IEditor
 		const gridDescriptor = createSerializedGrid({
 			orientation: this.toGridViewOrientation(
 				layout.orientation,
-				(this.gridWidget.orientation === Orientation.VERTICAL) ? Orientation.HORIZONTAL : Orientation.VERTICAL // fix https://github.com/Microsoft/vscode/issues/52975
+				this.isTwoDimensionalGrid() ?
+					this.gridWidget.orientation :			// preserve original orientation for 2-dimensional grids
+					orthogonal(this.gridWidget.orientation) // otherwise flip (fix https://github.com/Microsoft/vscode/issues/52975)
 			),
 			groups: layout.groups
 		});
@@ -444,6 +446,17 @@ export class EditorPart extends Part implements EditorGroupsServiceImpl, IEditor
 		}
 	}
 
+	private isTwoDimensionalGrid(): boolean {
+		const views = this.gridWidget.getViews();
+		if (isGridBranchNode(views)) {
+			// the grid is 2-dimensional if any children
+			// of the grid is a branch node
+			return views.children.some(child => isGridBranchNode(child));
+		}
+
+		return false;
+	}
+
 	addGroup(location: IEditorGroupView | GroupIdentifier, direction: GroupDirection, options?: IAddGroupOptions): IEditorGroupView {
 		const locationView = this.assertGroupView(location);
 

Original file line number	Diff line number	Diff line change
`@@ -27,14 +27,6 @@ export interface IView {`
`27`	`27`	`layout(width: number, height: number): void;`
`28`	`28`	`}`
`29`	`29`
`30`		`-/*`
`31`		`-TODO:`
`32`		`- - NEW: add a color to show a border where the sash is, similar to how other`
`33`		`- widgets have a color (e.g. Button, with applyStyles). Challenge is that this`
`34`		`- color has to be applied via JS and not CSS to not apply it to all views`
`35`		`- NOT CSS`
`36`		`-*/`
`37`		`-`
`38`	`30`	`export function orthogonal(orientation: Orientation): Orientation {`
`39`	`31`	`return orientation === Orientation.VERTICAL ? Orientation.HORIZONTAL : Orientation.VERTICAL;`
`40`	`32`	`}`