Introduce DebugSessionOptions.noDebug

isidorn · isidorn · commit cc06e19b15d6 · 2020-06-12T17:33:00.000+02:00
microsoft#99743
diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts
@@ -851,6 +851,13 @@ declare module 'vscode' {
 
 	//#region debug
 
+	export interface DebugSessionOptions {
+		/**
+		 * Controls whether this session should run without debugging, thus ignoring breakpoints.
+		 */
+		noDebug?: boolean;
+	}
+
 	// deprecated debug API
 
 	export interface DebugConfigurationProvider {
diff --git a/src/vs/workbench/api/browser/mainThreadDebugService.ts b/src/vs/workbench/api/browser/mainThreadDebugService.ts
@@ -229,7 +229,7 @@ export class MainThreadDebugService implements MainThreadDebugServiceShape, IDeb
 		const folderUri = folder ? uri.revive(folder) : undefined;
 		const launch = this.debugService.getConfigurationManager().getLaunch(folderUri);
 		const debugOptions: IDebugSessionOptions = {
-			noDebug: false,
+			noDebug: options.noDebug,
 			parentSession: this.getSession(options.parentSessionID),
 			repl: options.repl
 		};
diff --git a/src/vs/workbench/api/common/extHost.protocol.ts b/src/vs/workbench/api/common/extHost.protocol.ts
@@ -851,6 +851,7 @@ export interface IDebugConfiguration {
 export interface IStartDebuggingOptions {
 	parentSessionID?: DebugSessionUUID;
 	repl?: IDebugSessionReplMode;
+	noDebug?: boolean;
 }
 
 export interface MainThreadDebugServiceShape extends IDisposable {
diff --git a/src/vs/workbench/api/common/extHostDebugService.ts b/src/vs/workbench/api/common/extHostDebugService.ts
@@ -295,7 +295,8 @@ export class ExtHostDebugServiceBase implements IExtHostDebugService, ExtHostDeb
 	public startDebugging(folder: vscode.WorkspaceFolder | undefined, nameOrConfig: string | vscode.DebugConfiguration, options: vscode.DebugSessionOptions): Promise<boolean> {
 		return this._debugServiceProxy.$startDebugging(folder ? folder.uri : undefined, nameOrConfig, {
 			parentSessionID: options.parentSession ? options.parentSession.id : undefined,
-			repl: options.consoleMode === DebugConsoleMode.MergeWithParent ? 'mergeWithParent' : 'separate'
+			repl: options.consoleMode === DebugConsoleMode.MergeWithParent ? 'mergeWithParent' : 'separate',
+			noDebug: options.noDebug
 		});
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -851,6 +851,7 @@ export interface IDebugConfiguration {`
`851`	`851`	`export interface IStartDebuggingOptions {`
`852`	`852`	`parentSessionID?: DebugSessionUUID;`
`853`	`853`	`repl?: IDebugSessionReplMode;`
	`854`	`+ noDebug?: boolean;`
`854`	`855`	`}`
`855`	`856`
`856`	`857`	`export interface MainThreadDebugServiceShape extends IDisposable {`
Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,8 @@ export class ExtHostDebugServiceBase implements IExtHostDebugService, ExtHostDeb`
`295`	`295`	`public startDebugging(folder: vscode.WorkspaceFolder \| undefined, nameOrConfig: string \| vscode.DebugConfiguration, options: vscode.DebugSessionOptions): Promise<boolean> {`
`296`	`296`	`return this._debugServiceProxy.$startDebugging(folder ? folder.uri : undefined, nameOrConfig, {`
`297`	`297`	`parentSessionID: options.parentSession ? options.parentSession.id : undefined,`
`298`		`- repl: options.consoleMode === DebugConsoleMode.MergeWithParent ? 'mergeWithParent' : 'separate'`
	`298`	`+ repl: options.consoleMode === DebugConsoleMode.MergeWithParent ? 'mergeWithParent' : 'separate',`
	`299`	`+ noDebug: options.noDebug`
`299`	`300`	`});`
`300`	`301`	`}`
`301`	`302`