Revert fix for microsoft#78167 which causes a perf issue

joaomoreno · joaomoreno · commit cbb93657cd5b · 2019-08-28T16:12:37.000+02:00
Revert "fix microsoft#78768" This reverts commit b6a4220. Related to microsoft#77856 and microsoft#78167 Revert "fixes microsoft#78167" This reverts commit a417a06. Related to microsoft#77856 and microsoft#78167
diff --git a/src/vs/base/browser/ui/grid/gridview.ts b/src/vs/base/browser/ui/grid/gridview.ts
@@ -425,7 +425,6 @@ class BranchNode implements ISplitView, IDisposable {
 		}
 
 		this.splitview.setViewVisible(index, visible);
-		this._onDidChange.fire(undefined);
 	}
 
 	getChildCachedVisibleSize(index: number): number | undefined {
diff --git a/src/vs/base/browser/ui/splitview/splitview.css b/src/vs/base/browser/ui/splitview/splitview.css
@@ -72,4 +72,4 @@
 .monaco-split-view2.separator-border.vertical > .split-view-container > .split-view-view:not(:first-child)::before {
 	height: 1px;
 	width: 100%;
-}
+}
diff --git a/src/vs/base/browser/ui/splitview/splitview.ts b/src/vs/base/browser/ui/splitview/splitview.ts
@@ -125,12 +125,7 @@ abstract class ViewItem {
 		}
 	}
 
-	layout(_orthogonalSize: number | undefined): void {
-		this.container.scrollTop = 0;
-		this.container.scrollLeft = 0;
-	}
-
-	layoutView(orthogonalSize: number | undefined): void {
+	layout(orthogonalSize: number | undefined): void {
 		this.view.layout(this.size, orthogonalSize);
 	}
 
@@ -145,7 +140,6 @@ class VerticalViewItem extends ViewItem {
 	layout(orthogonalSize: number | undefined): void {
 		super.layout(orthogonalSize);
 		this.container.style.height = `${this.size}px`;
-		this.layoutView(orthogonalSize);
 	}
 }
 
@@ -154,7 +148,6 @@ class HorizontalViewItem extends ViewItem {
 	layout(orthogonalSize: number | undefined): void {
 		super.layout(orthogonalSize);
 		this.container.style.width = `${this.size}px`;
-		this.layoutView(orthogonalSize);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -425,7 +425,6 @@ class BranchNode implements ISplitView, IDisposable {`
`425`	`425`	`}`
`426`	`426`
`427`	`427`	`this.splitview.setViewVisible(index, visible);`
`428`		`- this._onDidChange.fire(undefined);`
`429`	`428`	`}`
`430`	`429`
`431`	`430`	`getChildCachedVisibleSize(index: number): number \| undefined {`
Original file line number	Diff line number	Diff line change
`@@ -125,12 +125,7 @@ abstract class ViewItem {`
`125`	`125`	`}`
`126`	`126`	`}`
`127`	`127`
`128`		`- layout(_orthogonalSize: number \| undefined): void {`
`129`		`- this.container.scrollTop = 0;`
`130`		`- this.container.scrollLeft = 0;`
`131`		`- }`
`132`		`-`
`133`		`- layoutView(orthogonalSize: number \| undefined): void {`
	`128`	`+ layout(orthogonalSize: number \| undefined): void {`
`134`	`129`	`this.view.layout(this.size, orthogonalSize);`
`135`	`130`	`}`
`136`	`131`
`@@ -145,7 +140,6 @@ class VerticalViewItem extends ViewItem {`
`145`	`140`	`layout(orthogonalSize: number \| undefined): void {`
`146`	`141`	`super.layout(orthogonalSize);`
`147`	`142`	this.container.style.height = `${this.size}px`;
`148`		`- this.layoutView(orthogonalSize);`
`149`	`143`	`}`
`150`	`144`	`}`
`151`	`145`
`@@ -154,7 +148,6 @@ class HorizontalViewItem extends ViewItem {`
`154`	`148`	`layout(orthogonalSize: number \| undefined): void {`
`155`	`149`	`super.layout(orthogonalSize);`
`156`	`150`	this.container.style.width = `${this.size}px`;
`157`		`- this.layoutView(orthogonalSize);`
`158`	`151`	`}`
`159`	`152`	`}`
`160`	`153`