Skip to content

Commit cb88dfc

Browse files
committed
Use execFile for Linux to terminate task
1 parent 405cf46 commit cb88dfc

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

src/vs/base/node/processes.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,12 @@ function terminateProcess(process: cp.ChildProcess, cwd?: string): Promise<Termi
6868
} else if (Platform.isLinux || Platform.isMacintosh) {
6969
try {
7070
const cmd = getPathFromAmdModule(require, 'vs/base/node/terminateProcess.sh');
71-
const killProcess = cp.spawn(cmd, [process.pid.toString()]);
7271
return new Promise((resolve, reject) => {
73-
killProcess.once('error', (err) => {
74-
resolve({ success: false, error: err });
75-
});
76-
killProcess.once('exit', (code, signal) => {
77-
if (code === 0) {
78-
resolve({ success: true });
72+
cp.execFile(cmd, [process.pid.toString()], { encoding: 'utf8', shell: true } as cp.ExecFileOptions, (err, stdout, stderr) => {
73+
if (err) {
74+
resolve({ success: false, error: err });
7975
} else {
80-
resolve({ success: false, code: code !== null ? code : TerminateResponseCode.Unknown });
76+
resolve({ success: true });
8177
}
8278
});
8379
});

0 commit comments

Comments
 (0)