Skip to content

Commit cadabab

Browse files
mjbvzmjbvz
authored
Mark _serviceBrand properties using declare (microsoft#99312)
_serviceBrand is only used for typing and should not result in emit Also adds readonly
1 parent 96ce46b commit cadabab

338 files changed

Lines changed: 459 additions & 459 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/vs/code/electron-browser/sharedProcess/sharedProcessMain.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ class MainProcessService implements IMainProcessService {
9595
private mainRouter: StaticRouter
9696
) { }
9797

98-
_serviceBrand: undefined;
98+
declare readonly _serviceBrand: undefined;
9999

100100
getChannel(channelName: string): IChannel {
101101
return this.server.getChannel(channelName, this.mainRouter);

‎src/vs/code/electron-main/auth.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ type Credentials = {
2323

2424
export class ProxyAuthHandler extends Disposable {
2525

26-
_serviceBrand: undefined;
26+
declare readonly _serviceBrand: undefined;
2727

2828
private retryCount = 0;
2929

‎src/vs/editor/browser/core/keybindingCancellation.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import { registerSingleton } from 'vs/platform/instantiation/common/extensions';
1717
const IEditorCancellationTokens = createDecorator<IEditorCancellationTokens>('IEditorCancelService');
1818

1919
interface IEditorCancellationTokens {
20-
_serviceBrand: undefined;
20+
readonly _serviceBrand: undefined;
2121
add(editor: ICodeEditor, cts: CancellationTokenSource): () => void;
2222
cancel(editor: ICodeEditor): void;
2323
}
@@ -26,7 +26,7 @@ const ctxCancellableOperation = new RawContextKey('cancellableOperation', false)
2626

2727
registerSingleton(IEditorCancellationTokens, class implements IEditorCancellationTokens {
2828

29-
_serviceBrand: undefined;
29+
declare readonly _serviceBrand: undefined;
3030

3131
private readonly _tokens = new WeakMap<ICodeEditor, { key: IContextKey<boolean>, tokens: LinkedList<CancellationTokenSource> }>();
3232

‎src/vs/editor/browser/services/abstractCodeEditorService.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { URI } from 'vs/base/common/uri';
1414

1515
export abstract class AbstractCodeEditorService extends Disposable implements ICodeEditorService {
1616

17-
_serviceBrand: undefined;
17+
declare readonly _serviceBrand: undefined;
1818

1919
private readonly _onCodeEditorAdd: Emitter<ICodeEditor> = this._register(new Emitter<ICodeEditor>());
2020
public readonly onCodeEditorAdd: Event<ICodeEditor> = this._onCodeEditorAdd.event;

‎src/vs/editor/browser/services/bulkEditService.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export interface IBulkEditResult {
2626
export type IBulkEditPreviewHandler = (edit: WorkspaceEdit, options?: IBulkEditOptions) => Promise<WorkspaceEdit>;
2727

2828
export interface IBulkEditService {
29-
_serviceBrand: undefined;
29+
readonly _serviceBrand: undefined;
3030

3131
hasPreviewHandler(): boolean;
3232

‎src/vs/editor/browser/services/codeEditorService.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { URI } from 'vs/base/common/uri';
1414
export const ICodeEditorService = createDecorator<ICodeEditorService>('codeEditorService');
1515

1616
export interface ICodeEditorService {
17-
_serviceBrand: undefined;
17+
readonly _serviceBrand: undefined;
1818

1919
readonly onCodeEditorAdd: Event<ICodeEditor>;
2020
readonly onCodeEditorRemove: Event<ICodeEditor>;

‎src/vs/editor/browser/services/openerService.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class EditorOpener implements IOpener {
8585

8686
export class OpenerService implements IOpenerService {
8787

88-
_serviceBrand: undefined;
88+
declare readonly _serviceBrand: undefined;
8989

9090
private readonly _openers = new LinkedList<IOpener>();
9191
private readonly _validators = new LinkedList<IValidator>();

‎src/vs/editor/common/services/editorWorkerService.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export interface IDiffComputationResult {
1919
}
2020

2121
export interface IEditorWorkerService {
22-
_serviceBrand: undefined;
22+
readonly _serviceBrand: undefined;
2323

2424
canComputeDiff(original: URI, modified: URI): boolean;
2525
computeDiff(original: URI, modified: URI, ignoreTrimWhitespace: boolean, maxComputationTime: number): Promise<IDiffComputationResult | null>;

‎src/vs/editor/common/services/editorWorkerServiceImpl.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ function canSyncModel(modelService: IModelService, resource: URI): boolean {
4646

4747
export class EditorWorkerServiceImpl extends Disposable implements IEditorWorkerService {
4848

49-
_serviceBrand: undefined;
49+
declare readonly _serviceBrand: undefined;
5050

5151
private readonly _modelService: IModelService;
5252
private readonly _workerManager: WorkerManager;

‎src/vs/editor/common/services/markerDecorationsServiceImpl.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class MarkerDecorations extends Disposable {
7070

7171
export class MarkerDecorationsService extends Disposable implements IMarkerDecorationsService {
7272

73-
_serviceBrand: undefined;
73+
declare readonly _serviceBrand: undefined;
7474

7575
private readonly _onDidChangeMarker = this._register(new Emitter<ITextModel>());
7676
readonly onDidChangeMarker: Event<ITextModel> = this._onDidChangeMarker.event;

0 commit comments

Comments
 (0)