Remove extra gating around selector

mjbvz · mjbvz · commit caa05dd6d5b8 · 2020-07-20T16:53:32.000-07:00
A registration should only need to if it targets all files, or just those on disk
diff --git a/extensions/typescript-language-features/src/languageProvider.ts b/extensions/typescript-language-features/src/languageProvider.ts
@@ -8,7 +8,6 @@ import * as vscode from 'vscode';
 import { DiagnosticKind } from './features/diagnostics';
 import FileConfigurationManager from './features/fileConfigurationManager';
 import { CachedResponse } from './tsServer/cachedResponse';
-import { ClientCapability } from './typescriptService';
 import TypeScriptServiceClient from './typescriptServiceClient';
 import { CommandManager } from './utils/commandManager';
 import { Disposable } from './utils/dispose';
@@ -50,12 +49,7 @@ export default class LanguageProvider extends Disposable {
 			}
 		}
 
-		if (this.client.capabilities.has(ClientCapability.EnhancedSyntax)) {
-			return { semantic, syntax };
-		}
-
-		// If we don't have a
-		return { semantic, syntax: semantic };
+		return { semantic, syntax };
 	}
 
 	private async registerProviders(): Promise<void> {

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ import * as vscode from 'vscode';`
`8`	`8`	`import { DiagnosticKind } from './features/diagnostics';`
`9`	`9`	`import FileConfigurationManager from './features/fileConfigurationManager';`
`10`	`10`	`import { CachedResponse } from './tsServer/cachedResponse';`
`11`		`-import { ClientCapability } from './typescriptService';`
`12`	`11`	`import TypeScriptServiceClient from './typescriptServiceClient';`
`13`	`12`	`import { CommandManager } from './utils/commandManager';`
`14`	`13`	`import { Disposable } from './utils/dispose';`
`@@ -50,12 +49,7 @@ export default class LanguageProvider extends Disposable {`
`50`	`49`	`}`
`51`	`50`	`}`
`52`	`51`
`53`		`- if (this.client.capabilities.has(ClientCapability.EnhancedSyntax)) {`
`54`		`- return { semantic, syntax };`
`55`		`- }`
`56`		`-`
`57`		`- // If we don't have a`
`58`		`- return { semantic, syntax: semantic };`
	`52`	`+ return { semantic, syntax };`
`59`	`53`	`}`
`60`	`54`
`61`	`55`	`private async registerProviders(): Promise<void> {`