Skip to content

Commit ca41e24

Browse files
committed
update comments
1 parent f0d09cf commit ca41e24

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

src/vs/platform/configuration/node/nodeConfigurationService.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ import { IEnvironmentService } from 'vs/platform/environment/common/environment'
2121
* Configuration service to be used in the node side.
2222
* TODO@Joao:
2323
* - defaults handling
24-
* - async reading
24+
* - async reading:
25+
* - read async at construction and on file change event. but if someone
26+
* calls getConfiguration before that first async call is done, just do
27+
* it sync
2528
*
2629
* At some point, an async get() on the configuration service would be
2730
* much easier to implement and reason about. IConfigurationService2?

0 commit comments

Comments
 (0)