Add view options update for list view.

rebornix · rebornix · commit c6017c33f4cd · 2020-03-24T19:41:44.000-07:00
diff --git a/src/vs/base/browser/ui/list/listView.ts b/src/vs/base/browser/ui/list/listView.ts
@@ -275,6 +275,12 @@ export class ListView<T> implements ISpliceable<T>, IDisposable {
 		this.layout();
 	}
 
+	updateOptions(options: IListViewOptions<T>) {
+		if (options.additionalScrollHeight !== undefined) {
+			this.additionalScrollHeight = options.additionalScrollHeight;
+		}
+	}
+
 	triggerScrollFromMouseWheelEvent(browserEvent: IMouseWheelEvent) {
 		this.scrollableElement.triggerScrollFromMouseWheelEvent(browserEvent);
 	}
diff --git a/src/vs/base/browser/ui/list/listWidget.ts b/src/vs/base/browser/ui/list/listWidget.ts
@@ -854,6 +854,7 @@ export interface IListOptions<T> {
 	readonly mouseSupport?: boolean;
 	readonly horizontalScrolling?: boolean;
 	readonly ariaProvider?: IAriaProvider<T>;
+	readonly additionalScrollHeight?: number;
 }
 
 export interface IListStyles {
@@ -1110,6 +1111,7 @@ class ListViewDragAndDrop<T> implements IListViewDragAndDrop<T> {
 export interface IListOptionsUpdate {
 	readonly enableKeyboardNavigation?: boolean;
 	readonly automaticKeyboardNavigation?: boolean;
+	readonly additionalScrollHeight?: number;
 }
 
 export class List<T> implements ISpliceable<T>, IDisposable {
@@ -1289,6 +1291,10 @@ export class List<T> implements ISpliceable<T>, IDisposable {
 		if (this.typeLabelController) {
 			this.typeLabelController.updateOptions(this._options);
 		}
+
+		if (optionsUpdate.additionalScrollHeight !== undefined) {
+			this.view.updateOptions(optionsUpdate);
+		}
 	}
 
 	get options(): IListOptions<T> {
diff --git a/src/vs/workbench/contrib/notebook/browser/notebookEditor.ts b/src/vs/workbench/contrib/notebook/browser/notebookEditor.ts
@@ -201,6 +201,7 @@ export class NotebookEditor extends BaseEditor implements INotebookEditor {
 				mouseSupport: true,
 				multipleSelectionSupport: false,
 				enableKeyboardNavigation: true,
+				additionalScrollHeight: 0,
 				overrideStyles: {
 					listBackground: editorBackground,
 					listActiveSelectionBackground: editorBackground,
@@ -419,6 +420,7 @@ export class NotebookEditor extends BaseEditor implements INotebookEditor {
 		DOM.toggleClass(this.rootElement, 'mid-width', dimension.width < 1000 && dimension.width >= 600);
 		DOM.toggleClass(this.rootElement, 'narrow-width', dimension.width < 600);
 		DOM.size(this.body, dimension.width, dimension.height);
+		this.list?.updateOptions({ additionalScrollHeight: dimension.height });
 		this.list?.layout(dimension.height, dimension.width);
 		this.eventDispatcher?.emit([new NotebookLayoutChangedEvent({ width: true, fontInfo: true }, this.getLayoutInfo())]);
 	}

Original file line number	Diff line number	Diff line change
`@@ -275,6 +275,12 @@ export class ListView<T> implements ISpliceable<T>, IDisposable {`
`275`	`275`	`this.layout();`
`276`	`276`	`}`
`277`	`277`
	`278`	`+ updateOptions(options: IListViewOptions<T>) {`
	`279`	`+ if (options.additionalScrollHeight !== undefined) {`
	`280`	`+ this.additionalScrollHeight = options.additionalScrollHeight;`
	`281`	`+ }`
	`282`	`+ }`
	`283`	`+`
`278`	`284`	`triggerScrollFromMouseWheelEvent(browserEvent: IMouseWheelEvent) {`
`279`	`285`	`this.scrollableElement.triggerScrollFromMouseWheelEvent(browserEvent);`
`280`	`286`	`}`
Original file line number	Diff line number	Diff line change
`@@ -854,6 +854,7 @@ export interface IListOptions<T> {`
`854`	`854`	`readonly mouseSupport?: boolean;`
`855`	`855`	`readonly horizontalScrolling?: boolean;`
`856`	`856`	`readonly ariaProvider?: IAriaProvider<T>;`
	`857`	`+ readonly additionalScrollHeight?: number;`
`857`	`858`	`}`
`858`	`859`
`859`	`860`	`export interface IListStyles {`
`@@ -1110,6 +1111,7 @@ class ListViewDragAndDrop<T> implements IListViewDragAndDrop<T> {`
`1110`	`1111`	`export interface IListOptionsUpdate {`
`1111`	`1112`	`readonly enableKeyboardNavigation?: boolean;`
`1112`	`1113`	`readonly automaticKeyboardNavigation?: boolean;`
	`1114`	`+ readonly additionalScrollHeight?: number;`
`1113`	`1115`	`}`
`1114`	`1116`
`1115`	`1117`	`export class List<T> implements ISpliceable<T>, IDisposable {`
`@@ -1289,6 +1291,10 @@ export class List<T> implements ISpliceable<T>, IDisposable {`
`1289`	`1291`	`if (this.typeLabelController) {`
`1290`	`1292`	`this.typeLabelController.updateOptions(this._options);`
`1291`	`1293`	`}`
	`1294`	`+`
	`1295`	`+ if (optionsUpdate.additionalScrollHeight !== undefined) {`
	`1296`	`+ this.view.updateOptions(optionsUpdate);`
	`1297`	`+ }`
`1292`	`1298`	`}`
`1293`	`1299`
`1294`	`1300`	`get options(): IListOptions<T> {`