Skip to content

Commit c561784

Browse files
chrmartichrmarti
committed
Clean up (microsoft#37212)
1 parent e99c765 commit c561784

4 files changed

Lines changed: 4 additions & 13 deletions

File tree

‎extensions/extension-editing/src/extension.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export function activate(context: vscode.ExtensionContext) {
1717
//package.json suggestions
1818
context.subscriptions.push(registerPackageDocumentCompletions());
1919

20-
context.subscriptions.push(new ExtensionLinter(context));
20+
context.subscriptions.push(new ExtensionLinter());
2121
}
2222

2323
const _linkProvider = new class implements vscode.DocumentLinkProvider {

‎extensions/extension-editing/src/extensionLinter.ts‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { parseTree, findNodeAtLocation, Node as JsonNode } from 'jsonc-parser';
1010
import * as nls from 'vscode-nls';
1111
import * as MarkdownItType from 'markdown-it';
1212

13-
import { languages, workspace, Disposable, ExtensionContext, TextDocument, Uri, Diagnostic, Range, DiagnosticSeverity, Position } from 'vscode';
13+
import { languages, workspace, Disposable, TextDocument, Uri, Diagnostic, Range, DiagnosticSeverity, Position } from 'vscode';
1414

1515
const product = require('../../../product.json');
1616
const allowedBadgeProviders: string[] = (product.extensionAllowedBadgeProviders || []).map(s => s.toLowerCase());
@@ -54,8 +54,7 @@ export class ExtensionLinter {
5454
private timer: NodeJS.Timer;
5555
private markdownIt: MarkdownItType.MarkdownIt;
5656

57-
// @ts-ignore unused property
58-
constructor(private context: ExtensionContext) {
57+
constructor() {
5958
this.disposables.push(
6059
workspace.onDidOpenTextDocument(document => this.queue(document)),
6160
workspace.onDidChangeTextDocument(event => this.queue(event.document)),

‎src/vs/workbench/parts/welcome/page/electron-browser/welcomePage.ts‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import { IConfigurationService, ConfigurationTarget } from 'vs/platform/configur
2121
import { localize } from 'vs/nls';
2222
import { Action } from 'vs/base/common/actions';
2323
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
24-
import { IExperimentService } from 'vs/platform/telemetry/common/experiments';
2524
import { IEnvironmentService } from 'vs/platform/environment/common/environment';
2625
import { Schemas } from 'vs/base/common/network';
2726
import { IBackupFileService } from 'vs/workbench/services/backup/common/backup';
@@ -32,7 +31,7 @@ import { used } from 'vs/workbench/parts/welcome/page/electron-browser/vs_code_w
3231
import { ILifecycleService, StartupKind, LifecyclePhase } from 'vs/platform/lifecycle/common/lifecycle';
3332
import { IDisposable, dispose } from 'vs/base/common/lifecycle';
3433
import { tildify } from 'vs/base/common/labels';
35-
import { IThemeService, registerThemingParticipant } from 'vs/platform/theme/common/themeService';
34+
import { registerThemingParticipant } from 'vs/platform/theme/common/themeService';
3635
import { registerColor, focusBorder, textLinkForeground, textLinkActiveForeground, foreground, descriptionForeground, contrastBorder, activeContrastBorder } from 'vs/platform/theme/common/colorRegistry';
3736
import { getExtraColor } from 'vs/workbench/parts/welcome/walkThrough/node/walkThroughUtils';
3837
import { IExtensionsWorkbenchService } from 'vs/workbench/parts/extensions/common/extensions';
@@ -241,10 +240,6 @@ class WelcomePage {
241240
@IExtensionTipsService private tipsService: IExtensionTipsService,
242241
@IExtensionsWorkbenchService private extensionsWorkbenchService: IExtensionsWorkbenchService,
243242
@ILifecycleService lifecycleService: ILifecycleService,
244-
// @ts-ignore unused injected service
245-
@IThemeService private themeService: IThemeService,
246-
// @ts-ignore unused injected service
247-
@IExperimentService private experimentService: IExperimentService,
248243
@ITelemetryService private telemetryService: ITelemetryService
249244
) {
250245
this.disposables.push(lifecycleService.onShutdown(() => this.dispose()));

‎src/vs/workbench/services/search/node/searchService.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import { Client, IIPCOptions } from 'vs/base/parts/ipc/node/ipc.cp';
1313
import { IProgress, LineMatch, FileMatch, ISearchComplete, ISearchProgressItem, QueryType, IFileMatch, ISearchQuery, ISearchConfiguration, ISearchService, pathIncludedInQuery, ISearchResultProvider } from 'vs/platform/search/common/search';
1414
import { IUntitledEditorService } from 'vs/workbench/services/untitled/common/untitledEditorService';
1515
import { IModelService } from 'vs/editor/common/services/modelService';
16-
import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
1716
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
1817
import { IRawSearch, ISerializedSearchComplete, ISerializedSearchProgressItem, ISerializedFileMatch, IRawSearchService, ITelemetryEvent } from './search';
1918
import { ISearchChannel, SearchChannelClient } from './searchIpc';
@@ -34,8 +33,6 @@ export class SearchService implements ISearchService {
3433
@IModelService private modelService: IModelService,
3534
@IUntitledEditorService private untitledEditorService: IUntitledEditorService,
3635
@IEnvironmentService environmentService: IEnvironmentService,
37-
// @ts-ignore unused injected service
38-
@IWorkspaceContextService private contextService: IWorkspaceContextService,
3936
@ITelemetryService private telemetryService: ITelemetryService,
4037
@IConfigurationService private configurationService: IConfigurationService
4138
) {

0 commit comments

Comments
 (0)