Can't click buttons on new notifications with a touch screen (fixes microsoft#46055)

Benjamin Pasero · Benjamin Pasero · commit c4e45c4dc6cd · 2018-03-19T11:07:39.000+01:00
diff --git a/src/vs/base/browser/ui/button/button.ts b/src/vs/base/browser/ui/button/button.ts
@@ -14,6 +14,7 @@ import { Color } from 'vs/base/common/color';
 import { mixin } from 'vs/base/common/objects';
 import { Event, Emitter } from 'vs/base/common/event';
 import { dispose, IDisposable } from 'vs/base/common/lifecycle';
+import { Gesture, EventType } from 'vs/base/browser/touch';
 
 export interface IButtonOptions extends IButtonStyles {
 	title?: boolean;
@@ -63,7 +64,9 @@ export class Button {
 			'role': 'button'
 		}).appendTo(container);
 
-		this.$el.on(DOM.EventType.CLICK, e => {
+		Gesture.addTarget(this.$el.getHTMLElement());
+
+		this.$el.on([DOM.EventType.CLICK, EventType.Tap], e => {
 			if (!this.enabled) {
 				DOM.EventHelper.stop(e);
 				return;
