Hide terminal hovers when closing panel

Tyriar · Tyriar · commit c1ef5b7aa88a · 2020-07-22T14:48:21.000-07:00
Fixes microsoft#101845
diff --git a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
@@ -840,6 +840,9 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
 				setTimeout(() => this.layout(this._timeoutDimension!), 0);
 			}
 		}
+		if (!visible) {
+			this._widgetManager.hideHovers();
+		}
 	}
 
 	public scrollDownLine(): void {
diff --git a/src/vs/workbench/contrib/terminal/browser/terminalView.ts b/src/vs/workbench/contrib/terminal/browser/terminalView.ts
@@ -110,6 +110,8 @@ export class TerminalViewPane extends ViewPane {
 				} else {
 					this.layoutBody(this._bodyDimensions.height, this._bodyDimensions.width);
 				}
+			} else {
+				this._terminalService.getActiveTab()?.setVisible(false);
 			}
 		}));
 
diff --git a/src/vs/workbench/contrib/terminal/browser/widgets/widgetManager.ts b/src/vs/workbench/contrib/terminal/browser/widgets/widgetManager.ts
@@ -5,11 +5,15 @@
 
 import { IDisposable } from 'vs/base/common/lifecycle';
 import { ITerminalWidget } from 'vs/workbench/contrib/terminal/browser/widgets/widgets';
+import { IHoverService } from 'vs/workbench/services/hover/browser/hover';
 
 export class TerminalWidgetManager implements IDisposable {
 	private _container: HTMLElement | undefined;
 	private _attached: Map<string, ITerminalWidget> = new Map();
 
+	constructor(@IHoverService private readonly _hoverService: IHoverService) {
+	}
+
 	attachToElement(terminalWrapper: HTMLElement) {
 		if (!this._container) {
 			this._container = document.createElement('div');
@@ -25,6 +29,10 @@ export class TerminalWidgetManager implements IDisposable {
 		}
 	}
 
+	hideHovers(): void {
+		this._hoverService.hideHover();
+	}
+
 	attachWidget(widget: ITerminalWidget): IDisposable | undefined {
 		if (!this._container) {
 			return;

Original file line number	Diff line number	Diff line change
`@@ -840,6 +840,9 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {`
`840`	`840`	`setTimeout(() => this.layout(this._timeoutDimension!), 0);`
`841`	`841`	`}`
`842`	`842`	`}`
	`843`	`+ if (!visible) {`
	`844`	`+ this._widgetManager.hideHovers();`
	`845`	`+ }`
`843`	`846`	`}`
`844`	`847`
`845`	`848`	`public scrollDownLine(): void {`
Original file line number	Diff line number	Diff line change
`@@ -110,6 +110,8 @@ export class TerminalViewPane extends ViewPane {`
`110`	`110`	`} else {`
`111`	`111`	`this.layoutBody(this._bodyDimensions.height, this._bodyDimensions.width);`
`112`	`112`	`}`
	`113`	`+ } else {`
	`114`	`+ this._terminalService.getActiveTab()?.setVisible(false);`
`113`	`115`	`}`
`114`	`116`	`}));`
`115`	`117`