Skip to content

Commit c1b4ba2

Browse files
committed
Make new setting editor telemetry event names consistent
1 parent 0505ae0 commit c1b4ba2

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/vs/workbench/parts/preferences/browser/settingsEditor2.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ export class SettingsEditor2 extends BaseEditor {
359359
};
360360

361361
/* __GDPR__
362-
"settingEditor.settingModified" : {
362+
"settingsEditor.settingModified" : {
363363
"key" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
364364
"query" : { "classification": "CustomerContent", "purpose": "FeatureInsight" },
365365
"groupId" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
@@ -370,7 +370,7 @@ export class SettingsEditor2 extends BaseEditor {
370370
"target" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
371371
}
372372
*/
373-
this.telemetryService.publicLog('settingEditor.settingModified', data);
373+
this.telemetryService.publicLog('settingsEditor.settingModified', data);
374374
}
375375

376376
private render(): TPromise<any> {
@@ -442,7 +442,7 @@ export class SettingsEditor2 extends BaseEditor {
442442
"requestCount" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true }
443443
}
444444
*/
445-
this.telemetryService.publicLog('defaultSettings.filter', data);
445+
this.telemetryService.publicLog('settingsEditor.filter', data);
446446
}
447447

448448
private localFilterPreferences(query: string): TPromise<void> {
@@ -473,15 +473,15 @@ export class SettingsEditor2 extends BaseEditor {
473473
return TPromise.wrapError(err);
474474
} else {
475475
/* __GDPR__
476-
"defaultSettings.searchError" : {
476+
"settingsEditor.searchError" : {
477477
"message": { "classification": "CallstackOrException", "purpose": "FeatureInsight" },
478478
"filter": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
479479
}
480480
*/
481481
const message = getErrorMessage(err).trim();
482482
if (message && message !== 'Error') {
483483
// "Error" = any generic network error
484-
this.telemetryService.publicLog('defaultSettings.searchError', { message, filter });
484+
this.telemetryService.publicLog('settingsEditor.searchError', { message, filter });
485485
this.logService.info('Setting search error: ' + message);
486486
}
487487
return null;

0 commit comments

Comments
 (0)