Fixes microsoft#84523: Pass in comparator when using Array<number>.sort()

alexdima · alexdima · commit c197f24c6915 · 2019-12-06T01:11:56.000+01:00
diff --git a/src/vs/editor/browser/viewParts/currentLineHighlight/currentLineHighlight.ts b/src/vs/editor/browser/viewParts/currentLineHighlight/currentLineHighlight.ts
@@ -57,7 +57,7 @@ export abstract class AbstractLineHighlightOverlay extends DynamicViewOverlay {
 		const renderSelections = isRenderedUsingBorder ? this._selections.slice(0, 1) : this._selections;
 
 		const cursorsLineNumbers = renderSelections.map(s => s.positionLineNumber);
-		cursorsLineNumbers.sort();
+		cursorsLineNumbers.sort((a, b) => a - b);
 		if (!arrays.equals(this._cursorLineNumbers, cursorsLineNumbers)) {
 			this._cursorLineNumbers = cursorsLineNumbers;
 			hasChanged = true;
diff --git a/src/vs/editor/common/config/editorOptions.ts b/src/vs/editor/common/config/editorOptions.ts
@@ -2271,7 +2271,7 @@ class EditorRulers extends SimpleEditorOption<EditorOption.rulers, number[]> {
 			for (let value of input) {
 				rulers.push(EditorIntOption.clampedInt(value, 0, 0, 10000));
 			}
-			rulers.sort();
+			rulers.sort((a, b) => a - b);
 			return rulers;
 		}
 		return this.defaultValue;

Original file line number	Diff line number	Diff line change
`@@ -2271,7 +2271,7 @@ class EditorRulers extends SimpleEditorOption<EditorOption.rulers, number[]> {`
`2271`	`2271`	`for (let value of input) {`
`2272`	`2272`	`rulers.push(EditorIntOption.clampedInt(value, 0, 0, 10000));`
`2273`	`2273`	`}`
`2274`		`- rulers.sort();`
	`2274`	`+ rulers.sort((a, b) => a - b);`
`2275`	`2275`	`return rulers;`
`2276`	`2276`	`}`
`2277`	`2277`	`return this.defaultValue;`