🐛 handle proxy auth window closing

joaomoreno · joaomoreno · commit bf7c48e9a76b · 2017-04-13T21:49:09.000+02:00
diff --git a/src/vs/code/electron-main/auth.ts b/src/vs/code/electron-main/auth.ts
@@ -77,8 +77,13 @@ export class ProxyAuthHandler {
 		const javascript = 'promptForCredentials(' + JSON.stringify(data) + ')';
 
 		event.preventDefault();
+
+		const onWindowClose = () => cb('', '');
+		win.on('close', onWindowClose);
+
 		win.webContents.executeJavaScript(javascript, true).then(({ username, password }: Credentials) => {
 			cb(username, password);
+			win.removeListener('close', onWindowClose);
 			win.close();
 		});
 	}
