Skip to content

Commit bf6db83

Browse files
jriekenjrieken
committed
unused imports and other tslint findings
1 parent 67fa01e commit bf6db83

5 files changed

Lines changed: 26 additions & 60 deletions

File tree

‎src/vs/editor/contrib/format/common/format.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@
77

88
import {IFormattingSupport, IFormattingOptions} from 'vs/editor/common/modes';
99
import LanguageFeatureRegistry from 'vs/editor/common/modes/languageFeatureRegistry';
10-
import {onUnexpectedError, illegalArgument} from 'vs/base/common/errors';
10+
import {illegalArgument} from 'vs/base/common/errors';
1111
import URI from 'vs/base/common/uri';
12-
import {IAction, Action} from 'vs/base/common/actions';
1312
import {IModelService} from 'vs/editor/common/services/modelService';
1413
import {TPromise} from 'vs/base/common/winjs.base';
1514
import {IModel, IRange, IPosition, ISingleEditOperation} from 'vs/editor/common/editorCommon';

‎src/vs/workbench/api/common/extHostApiCommands.ts‎

Lines changed: 7 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -5,36 +5,18 @@
55
'use strict';
66

77
import URI from 'vs/base/common/uri';
8-
import Event, {Emitter} from 'vs/base/common/event';
9-
import Severity from 'vs/base/common/severity';
10-
import {DefaultFilter} from 'vs/editor/common/modes/modesFilters';
118
import {TPromise} from 'vs/base/common/winjs.base';
12-
import {onUnexpectedError} from 'vs/base/common/errors';
13-
import {sequence} from 'vs/base/common/async';
14-
import {Range as EditorRange} from 'vs/editor/common/core/range';
159
import {IDisposable} from 'vs/base/common/lifecycle';
16-
import {IKeybindingService} from 'vs/platform/keybinding/common/keybindingService';
17-
import {Remotable, IThreadService} from 'vs/platform/thread/common/thread';
1810
import * as vscode from 'vscode';
1911
import * as typeConverters from 'vs/workbench/api/common/pluginHostTypeConverters';
2012
import * as types from 'vs/workbench/api/common/pluginHostTypes';
21-
import {IPosition, IRange, ISingleEditOperation} from 'vs/editor/common/editorCommon';
13+
import {ISingleEditOperation} from 'vs/editor/common/editorCommon';
2214
import * as modes from 'vs/editor/common/modes';
2315
import {ICommandHandlerDescription} from 'vs/platform/keybinding/common/keybindingService';
24-
import {CancellationTokenSource} from 'vs/base/common/cancellation';
25-
import {PluginHostModelService} from 'vs/workbench/api/common/pluginHostDocuments';
26-
import {IMarkerService, IMarker} from 'vs/platform/markers/common/markers';
27-
import {PluginHostCommands, MainThreadCommands} from 'vs/workbench/api/common/pluginHostCommands';
28-
import {DeclarationRegistry} from 'vs/editor/contrib/goToDeclaration/common/goToDeclaration';
29-
import {ExtraInfoRegistry} from 'vs/editor/contrib/hover/common/hover';
30-
import {OccurrencesRegistry} from 'vs/editor/contrib/wordHighlighter/common/wordHighlighter';
31-
import {ReferenceRegistry} from 'vs/editor/contrib/referenceSearch/common/referenceSearch';
32-
import {IQuickFix2, QuickFixRegistry, getQuickFixes} from 'vs/editor/contrib/quickFix/common/quickFix';
16+
import {PluginHostCommands} from 'vs/workbench/api/common/pluginHostCommands';
17+
import {IQuickFix2} from 'vs/editor/contrib/quickFix/common/quickFix';
3318
import {IOutline} from 'vs/editor/contrib/quickOpen/common/quickOpen';
34-
import LanguageFeatureRegistry from 'vs/editor/common/modes/languageFeatureRegistry';
35-
import {NavigateTypesSupportRegistry, INavigateTypesSupport, ITypeBearing} from 'vs/workbench/parts/search/common/search'
36-
import {RenameRegistry} from 'vs/editor/contrib/rename/common/rename';
37-
import {FormatRegistry, FormatOnTypeRegistry} from 'vs/editor/contrib/format/common/format';
19+
import {ITypeBearing} from 'vs/workbench/parts/search/common/search'
3820
import {ICodeLensData} from 'vs/editor/contrib/codelens/common/codelens';
3921

4022
export class ExtHostApiCommands {
@@ -313,7 +295,8 @@ export class ExtHostApiCommands {
313295
return this._commands.executeCommand<ICodeLensData[]>('_executeCodeLensProvider', args).then(value => {
314296
if (Array.isArray(value)) {
315297
return value.map(item => {
316-
return new types.CodeLens(typeConverters.toRange(item.symbol.range),
298+
return new types.CodeLens(
299+
typeConverters.toRange(item.symbol.range),
317300
typeConverters.Command.to(item.symbol.command));
318301
});
319302
}
@@ -358,4 +341,4 @@ export class ExtHostApiCommands {
358341
}
359342
});
360343
}
361-
}
344+
}

‎src/vs/workbench/api/common/extHostLanguageFeatures.ts‎

Lines changed: 16 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -5,32 +5,26 @@
55
'use strict';
66

77
import URI from 'vs/base/common/uri';
8-
import Event, {Emitter} from 'vs/base/common/event';
9-
import Severity from 'vs/base/common/severity';
108
import {DefaultFilter} from 'vs/editor/common/modes/modesFilters';
119
import {TPromise} from 'vs/base/common/winjs.base';
12-
import {onUnexpectedError} from 'vs/base/common/errors';
13-
import {sequence} from 'vs/base/common/async';
14-
import {Range as EditorRange} from 'vs/editor/common/core/range';
1510
import {IDisposable} from 'vs/base/common/lifecycle';
16-
import {IKeybindingService} from 'vs/platform/keybinding/common/keybindingService';
1711
import {Remotable, IThreadService} from 'vs/platform/thread/common/thread';
12+
import {Range as EditorRange} from 'vs/editor/common/core/range';
1813
import * as vscode from 'vscode';
1914
import * as TypeConverters from 'vs/workbench/api/common/pluginHostTypeConverters';
20-
import {Position, Range, SymbolKind, DocumentHighlightKind, Disposable, Diagnostic, DiagnosticSeverity, Location, SignatureHelp, CompletionItemKind} from 'vs/workbench/api/common/pluginHostTypes';
15+
import {Range, DocumentHighlightKind, Disposable, Diagnostic, SignatureHelp} from 'vs/workbench/api/common/pluginHostTypes';
2116
import {IPosition, IRange, ISingleEditOperation} from 'vs/editor/common/editorCommon';
2217
import * as modes from 'vs/editor/common/modes';
2318
import {CancellationTokenSource} from 'vs/base/common/cancellation';
2419
import {PluginHostModelService} from 'vs/workbench/api/common/pluginHostDocuments';
2520
import {IMarkerService, IMarker} from 'vs/platform/markers/common/markers';
26-
import {PluginHostCommands, MainThreadCommands} from 'vs/workbench/api/common/pluginHostCommands';
21+
import {PluginHostCommands} from 'vs/workbench/api/common/pluginHostCommands';
2722
import {DeclarationRegistry} from 'vs/editor/contrib/goToDeclaration/common/goToDeclaration';
2823
import {ExtraInfoRegistry} from 'vs/editor/contrib/hover/common/hover';
2924
import {OccurrencesRegistry} from 'vs/editor/contrib/wordHighlighter/common/wordHighlighter';
3025
import {ReferenceRegistry} from 'vs/editor/contrib/referenceSearch/common/referenceSearch';
3126
import {QuickFixRegistry} from 'vs/editor/contrib/quickFix/common/quickFix';
3227
import {OutlineRegistry, IOutlineEntry, IOutlineSupport} from 'vs/editor/contrib/quickOpen/common/quickOpen';
33-
import LanguageFeatureRegistry from 'vs/editor/common/modes/languageFeatureRegistry';
3428
import {NavigateTypesSupportRegistry, INavigateTypesSupport, ITypeBearing} from 'vs/workbench/parts/search/common/search'
3529
import {RenameRegistry} from 'vs/editor/contrib/rename/common/rename';
3630
import {FormatRegistry, FormatOnTypeRegistry} from 'vs/editor/contrib/format/common/format';
@@ -256,7 +250,7 @@ class ReferenceAdapter implements modes.IReferenceSupport {
256250
this._provider = provider;
257251
}
258252

259-
canFindReferences():boolean {
253+
canFindReferences(): boolean {
260254
return true
261255
}
262256

@@ -376,7 +370,7 @@ class OnTypeFormattingAdapter implements modes.IFormattingSupport {
376370
this._provider = provider;
377371
}
378372

379-
autoFormatTriggerCharacters = []; // not here
373+
autoFormatTriggerCharacters: string[] = []; // not here
380374

381375
formatAfterKeystroke(resource: URI, position: IPosition, ch: string, options: modes.IFormattingOptions): TPromise<ISingleEditOperation[]> {
382376

@@ -548,7 +542,7 @@ class SuggestAdapter implements modes.ISuggestSupport {
548542
});
549543
}
550544

551-
getFilter(): any{
545+
getFilter(): any {
552546
throw new Error('illegal state');
553547
}
554548
getTriggerCharacters(): string[] {
@@ -601,7 +595,7 @@ type Adapter = OutlineAdapter | CodeLensAdapter | DeclarationAdapter | ExtraInfo
601595
@Remotable.PluginHostContext('ExtHostLanguageFeatures')
602596
export class ExtHostLanguageFeatures {
603597

604-
private static _handlePool = 0;
598+
private static _handlePool: number = 0;
605599

606600
private _proxy: MainThreadLanguageFeatures;
607601
private _documents: PluginHostModelService;
@@ -642,7 +636,7 @@ export class ExtHostLanguageFeatures {
642636
return this._createDisposable(handle);
643637
}
644638

645-
$getOutline(handle: number, resource: URI): TPromise<IOutlineEntry[]>{
639+
$getOutline(handle: number, resource: URI): TPromise<IOutlineEntry[]> {
646640
return this._withAdapter(handle, OutlineAdapter, adapter => adapter.getOutline(resource));
647641
}
648642

@@ -659,7 +653,7 @@ export class ExtHostLanguageFeatures {
659653
return this._withAdapter(handle, CodeLensAdapter, adapter => adapter.findCodeLensSymbols(resource));
660654
}
661655

662-
$resolveCodeLensSymbol(handle:number, resource: URI, symbol: modes.ICodeLensSymbol): TPromise<modes.ICodeLensSymbol> {
656+
$resolveCodeLensSymbol(handle: number, resource: URI, symbol: modes.ICodeLensSymbol): TPromise<modes.ICodeLensSymbol> {
663657
return this._withAdapter(handle, CodeLensAdapter, adapter => adapter.resolveCodeLensSymbol(resource, symbol));
664658
}
665659

@@ -685,7 +679,7 @@ export class ExtHostLanguageFeatures {
685679
return this._createDisposable(handle);
686680
}
687681

688-
$computeInfo(handle:number, resource: URI, position: IPosition): TPromise<modes.IComputeExtraInfoResult> {
682+
$computeInfo(handle: number, resource: URI, position: IPosition): TPromise<modes.IComputeExtraInfoResult> {
689683
return this._withAdapter(handle, ExtraInfoAdapter, adpater => adpater.computeInfo(resource, position));
690684
}
691685

@@ -698,7 +692,7 @@ export class ExtHostLanguageFeatures {
698692
return this._createDisposable(handle);
699693
}
700694

701-
$findOccurrences(handle:number, resource: URI, position: IPosition): TPromise<modes.IOccurence[]> {
695+
$findOccurrences(handle: number, resource: URI, position: IPosition): TPromise<modes.IOccurence[]> {
702696
return this._withAdapter(handle, OccurrencesAdapter, adapter => adapter.findOccurrences(resource, position));
703697
}
704698

@@ -724,7 +718,7 @@ export class ExtHostLanguageFeatures {
724718
return this._createDisposable(handle);
725719
}
726720

727-
$getQuickFixes(handle:number, resource: URI, range: IRange, marker: IMarker[]): TPromise<modes.IQuickFix[]> {
721+
$getQuickFixes(handle: number, resource: URI, range: IRange, marker: IMarker[]): TPromise<modes.IQuickFix[]> {
728722
return this._withAdapter(handle, QuickFixAdapter, adapter => adapter.getQuickFixes(resource, range, marker));
729723
}
730724

@@ -741,7 +735,7 @@ export class ExtHostLanguageFeatures {
741735
return this._createDisposable(handle);
742736
}
743737

744-
$formatDocument(handle: number, resource: URI, options: modes.IFormattingOptions): TPromise<ISingleEditOperation[]>{
738+
$formatDocument(handle: number, resource: URI, options: modes.IFormattingOptions): TPromise<ISingleEditOperation[]> {
745739
return this._withAdapter(handle, DocumentFormattingAdapter, adapter => adapter.formatDocument(resource, options));
746740
}
747741

@@ -752,7 +746,7 @@ export class ExtHostLanguageFeatures {
752746
return this._createDisposable(handle);
753747
}
754748

755-
$formatRange(handle: number, resource: URI, range: IRange, options: modes.IFormattingOptions): TPromise<ISingleEditOperation[]>{
749+
$formatRange(handle: number, resource: URI, range: IRange, options: modes.IFormattingOptions): TPromise<ISingleEditOperation[]> {
756750
return this._withAdapter(handle, RangeFormattingAdapter, adapter => adapter.formatRange(resource, range, options));
757751
}
758752

@@ -763,7 +757,7 @@ export class ExtHostLanguageFeatures {
763757
return this._createDisposable(handle);
764758
}
765759

766-
$formatAfterKeystroke(handle: number, resource: URI, position: IPosition, ch: string, options: modes.IFormattingOptions): TPromise<ISingleEditOperation[]>{
760+
$formatAfterKeystroke(handle: number, resource: URI, position: IPosition, ch: string, options: modes.IFormattingOptions): TPromise<ISingleEditOperation[]> {
767761
return this._withAdapter(handle, OnTypeFormattingAdapter, adapter => adapter.formatAfterKeystroke(resource, position, ch, options));
768762
}
769763

@@ -1036,4 +1030,4 @@ export class MainThreadLanguageFeatures {
10361030
});
10371031
return undefined;
10381032
}
1039-
}
1033+
}

‎src/vs/workbench/api/common/extHostLanguages.ts‎

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,8 @@
44
*--------------------------------------------------------------------------------------------*/
55
'use strict';
66

7-
import URI from 'vs/base/common/uri';
8-
import Event, {Emitter} from 'vs/base/common/event';
9-
import {IDisposable, disposeAll} from 'vs/base/common/lifecycle';
107
import {TPromise} from 'vs/base/common/winjs.base';
118
import {Remotable, IThreadService} from 'vs/platform/thread/common/thread';
12-
import {PluginHostModelService} from 'vs/workbench/api/common/pluginHostDocuments';
13-
import {ISingleEditOperation, ISelection, IRange, IInternalIndentationOptions} from 'vs/editor/common/editorCommon';
14-
import {ICodeEditorService} from 'vs/editor/common/services/codeEditorService';
15-
import {IModelService} from 'vs/editor/common/services/modelService';
16-
import {MainThreadEditorsTracker, MainThreadTextEditor, ITextEditorConfiguration} from 'vs/workbench/api/common/mainThreadEditors';
17-
import * as TypeConverters from './pluginHostTypeConverters';
18-
import {TextEditorSelectionChangeEvent, TextEditorOptionsChangeEvent} from 'vscode';
199
import {IEditorModesRegistry, Extensions} from 'vs/editor/common/modes/modesRegistry';
2010
import {Registry} from 'vs/platform/platform';
2111
import {INullService} from 'vs/platform/instantiation/common/instantiation';
@@ -45,4 +35,4 @@ export class MainThreadLanguages {
4535
_getLanguages(): TPromise<string[]> {
4636
return TPromise.as(this._registry.getRegisteredModes());
4737
}
48-
}
38+
}

‎src/vs/workbench/api/common/extHostOutputService.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,4 +109,4 @@ export class MainThreadOutputService {
109109
}
110110
}
111111
}
112-
}
112+
}

0 commit comments

Comments
 (0)