details -> type

octref · octref · commit be285784f259 · 2020-01-21T09:46:13.000+01:00
diff --git a/src/vs/editor/common/modes.ts b/src/vs/editor/common/modes.ts
@@ -380,14 +380,11 @@ export interface CompletionItemLabel {
 	// signature?: string; // parameters
 	// The fully qualified name, like package name, file path etc
 	// qualifier?: string;
-	// The return-type of a function or type of a property, variable etc
-	// type?: string;
 
 	/**
-	 * Details of the completion item that is rendered less
-	 * prominent to the right.
+	 * The return-type of a function or type of a property, variable
 	 */
-	details?: string;
+	type?: string;
 }
 
 export const enum CompletionItemTag {
diff --git a/src/vs/editor/contrib/suggest/suggestWidget.ts b/src/vs/editor/contrib/suggest/suggestWidget.ts
@@ -241,7 +241,7 @@ class ItemRenderer implements IListRenderer<CompletionItem, ISuggestionTemplateD
 			data.detailsLabel.textContent = (suggestion.detail || '').replace(/\n.*$/m, '');
 			removeClass(data.right, 'always-show-details');
 		} else {
-			data.detailsLabel.textContent = (suggestion.label.details || '').replace(/\n.*$/m, '');
+			data.detailsLabel.textContent = (suggestion.label.type || '').replace(/\n.*$/m, '');
 			addClass(data.right, 'always-show-details');
 		}
 
diff --git a/src/vs/monaco.d.ts b/src/vs/monaco.d.ts
@@ -5202,10 +5202,9 @@ declare namespace monaco.languages {
 		 */
 		name: string;
 		/**
-		 * Details of the completion item that is rendered less
-		 * prominent to the right.
+		 * The return-type of a function or type of a property, variable
 		 */
-		details?: string;
+		type?: string;
 	}
 
 	export enum CompletionItemTag {
diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts
@@ -1396,10 +1396,9 @@ declare module 'vscode' {
 		// signature?: string; // parameters
 		// The fully qualified name, like package name, file path etc
 		// qualifier?: string;
-		// The return-type of a function or type of a property, variable etc
-		// type?: string;
 
-		details?: string;
+		// The return-type of a function or type of a property, variable etc
+		type?: string;
 	}
 
 	//#endregion
diff --git a/src/vs/workbench/api/common/extHostTypes.ts b/src/vs/workbench/api/common/extHostTypes.ts
@@ -1358,8 +1358,9 @@ export enum CompletionItemTag {
 
 export interface CompletionItemLabel {
 	name: string;
-	// description?: string;
-	details?: string;
+	// signature?: string; // parameters
+	// qualifier?: string;
+	type?: string;
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,7 @@ class ItemRenderer implements IListRenderer<CompletionItem, ISuggestionTemplateD`
`241`	`241`	`data.detailsLabel.textContent = (suggestion.detail \|\| '').replace(/\n.*$/m, '');`
`242`	`242`	`removeClass(data.right, 'always-show-details');`
`243`	`243`	`} else {`
`244`		`- data.detailsLabel.textContent = (suggestion.label.details \|\| '').replace(/\n.*$/m, '');`
	`244`	`+ data.detailsLabel.textContent = (suggestion.label.type \|\| '').replace(/\n.*$/m, '');`
`245`	`245`	`addClass(data.right, 'always-show-details');`
`246`	`246`	`}`
`247`	`247`
Original file line number	Diff line number	Diff line change
`@@ -1358,8 +1358,9 @@ export enum CompletionItemTag {`
`1358`	`1358`
`1359`	`1359`	`export interface CompletionItemLabel {`
`1360`	`1360`	`name: string;`
`1361`		`- // description?: string;`
`1362`		`- details?: string;`
	`1361`	`+ // signature?: string; // parameters`
	`1362`	`+ // qualifier?: string;`
	`1363`	`+ type?: string;`
`1363`	`1364`	`}`
`1364`	`1365`
`1365`	`1366`