Skip to content

Commit bd30090

Browse files
isidornisidorn
authored
Merge pull request microsoft#53534 from Microsoft/isidorn/removeTerminalMenu
menu: remove terminal menu
2 parents 86cb609 + 1fe0041 commit bd30090

3 files changed

Lines changed: 1 addition & 105 deletions

File tree

‎src/vs/platform/actions/common/actions.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ export class MenuId {
9797
static readonly MenubarWindowMenu = new MenuId();
9898
static readonly MenubarPreferencesMenu = new MenuId();
9999
static readonly MenubarHelpMenu = new MenuId();
100-
static readonly MenubarTerminalMenu = new MenuId();
101100

102101
readonly id: string = String(MenuId.ID++);
103102
}

‎src/vs/workbench/browser/parts/menubar/menubar.contribution.ts‎

Lines changed: 0 additions & 100 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ layoutMenuRegistration();
1616
goMenuRegistration();
1717
debugMenuRegistration();
1818
tasksMenuRegistration();
19-
terminalMenuRegistration();
2019

2120
if (isMacintosh) {
2221
windowMenuRegistration();
@@ -1494,102 +1493,3 @@ function helpMenuRegistration() {
14941493
order: 1
14951494
});
14961495
}
1497-
1498-
function terminalMenuRegistration() {
1499-
1500-
// Manage
1501-
1502-
MenuRegistry.appendMenuItem(MenuId.MenubarTerminalMenu, {
1503-
group: '1_manage',
1504-
command: {
1505-
id: 'workbench.action.terminal.new',
1506-
title: nls.localize({ key: 'miNewTerminal', comment: ['&& denotes a mnemonic'] }, "&&New Terminal")
1507-
},
1508-
order: 1
1509-
});
1510-
1511-
MenuRegistry.appendMenuItem(MenuId.MenubarTerminalMenu, {
1512-
group: '1_manage',
1513-
command: {
1514-
id: 'workbench.action.terminal.split',
1515-
title: nls.localize({ key: 'miSplitTerminal', comment: ['&& denotes a mnemonic'] }, "&&Split Terminal")
1516-
},
1517-
order: 2
1518-
});
1519-
1520-
MenuRegistry.appendMenuItem(MenuId.MenubarTerminalMenu, {
1521-
group: '1_manage',
1522-
command: {
1523-
id: 'workbench.action.terminal.kill',
1524-
title: nls.localize({ key: 'miKillTerminal', comment: ['&& denotes a mnemonic'] }, "&&Kill Terminal")
1525-
},
1526-
order: 3
1527-
});
1528-
1529-
// Run
1530-
1531-
MenuRegistry.appendMenuItem(MenuId.MenubarTerminalMenu, {
1532-
group: '2_run',
1533-
command: {
1534-
id: 'workbench.action.terminal.clear',
1535-
title: nls.localize({ key: 'miClear', comment: ['&& denotes a mnemonic'] }, "&&Clear")
1536-
},
1537-
order: 1
1538-
});
1539-
1540-
MenuRegistry.appendMenuItem(MenuId.MenubarTerminalMenu, {
1541-
group: '2_run',
1542-
command: {
1543-
id: 'workbench.action.terminal.runActiveFile',
1544-
title: nls.localize({ key: 'miRunActiveFile', comment: ['&& denotes a mnemonic'] }, "Run &&Active File")
1545-
},
1546-
order: 2
1547-
});
1548-
1549-
MenuRegistry.appendMenuItem(MenuId.MenubarTerminalMenu, {
1550-
group: '2_run',
1551-
command: {
1552-
id: 'workbench.action.terminal.runSelectedFile',
1553-
title: nls.localize({ key: 'miRunSelectedText', comment: ['&& denotes a mnemonic'] }, "Run &&Selected Text")
1554-
},
1555-
order: 3
1556-
});
1557-
1558-
// Selection
1559-
1560-
MenuRegistry.appendMenuItem(MenuId.MenubarTerminalMenu, {
1561-
group: '3_selection',
1562-
command: {
1563-
id: 'workbench.action.terminal.scrollToPreviousCommand',
1564-
title: nls.localize({ key: 'miScrollToPreviousCommand', comment: ['&& denotes a mnemonic'] }, "Scroll To Previous Command")
1565-
},
1566-
order: 1
1567-
});
1568-
1569-
MenuRegistry.appendMenuItem(MenuId.MenubarTerminalMenu, {
1570-
group: '3_selection',
1571-
command: {
1572-
id: 'workbench.action.terminal.scrollToNextCommand',
1573-
title: nls.localize({ key: 'miScrollToNextCommand', comment: ['&& denotes a mnemonic'] }, "Scroll To Next Command")
1574-
},
1575-
order: 2
1576-
});
1577-
1578-
MenuRegistry.appendMenuItem(MenuId.MenubarTerminalMenu, {
1579-
group: '3_selection',
1580-
command: {
1581-
id: 'workbench.action.terminal.selectToPreviousCommand',
1582-
title: nls.localize({ key: 'miSelectToPreviousCommand', comment: ['&& denotes a mnemonic'] }, "Select To Previous Command")
1583-
},
1584-
order: 3
1585-
});
1586-
1587-
MenuRegistry.appendMenuItem(MenuId.MenubarTerminalMenu, {
1588-
group: '3_selection',
1589-
command: {
1590-
id: 'workbench.action.terminal.selectToNextCommand',
1591-
title: nls.localize({ key: 'miSelectToNextCommand', comment: ['&& denotes a mnemonic'] }, "Select To Next Command")
1592-
},
1593-
order: 4
1594-
});
1595-
}

‎src/vs/workbench/browser/parts/menubar/menubarPart.ts‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ export class MenubarPart extends Part {
6060
'Selection': IMenu;
6161
'View': IMenu;
6262
'Go': IMenu;
63-
'Terminal': IMenu;
6463
'Debug': IMenu;
6564
'Tasks': IMenu;
6665
'Window'?: IMenu;
@@ -74,7 +73,6 @@ export class MenubarPart extends Part {
7473
'Selection': nls.localize({ key: 'mSelection', comment: ['&& denotes a mnemonic'] }, "&&Selection"),
7574
'View': nls.localize({ key: 'mView', comment: ['&& denotes a mnemonic'] }, "&&View"),
7675
'Go': nls.localize({ key: 'mGoto', comment: ['&& denotes a mnemonic'] }, "&&Go"),
77-
'Terminal': nls.localize({ key: 'mTerminal', comment: ['&& denotes a mnemonic'] }, "&&Terminal"),
7876
'Debug': nls.localize({ key: 'mDebug', comment: ['&& denotes a mnemonic'] }, "&&Debug"),
7977
'Tasks': nls.localize({ key: 'mTasks', comment: ['&& denotes a mnemonic'] }, "&&Tasks"),
8078
'Help': nls.localize({ key: 'mHelp', comment: ['&& denotes a mnemonic'] }, "&&Help")
@@ -125,7 +123,6 @@ export class MenubarPart extends Part {
125123
'Selection': this._register(this.menuService.createMenu(MenuId.MenubarSelectionMenu, this.contextKeyService)),
126124
'View': this._register(this.menuService.createMenu(MenuId.MenubarViewMenu, this.contextKeyService)),
127125
'Go': this._register(this.menuService.createMenu(MenuId.MenubarGoMenu, this.contextKeyService)),
128-
'Terminal': this._register(this.menuService.createMenu(MenuId.MenubarTerminalMenu, this.contextKeyService)),
129126
'Debug': this._register(this.menuService.createMenu(MenuId.MenubarDebugMenu, this.contextKeyService)),
130127
'Tasks': this._register(this.menuService.createMenu(MenuId.MenubarTasksMenu, this.contextKeyService)),
131128
'Help': this._register(this.menuService.createMenu(MenuId.MenubarHelpMenu, this.contextKeyService))
@@ -862,4 +859,4 @@ class ModifierKeyEmitter extends Emitter<IModifierKeyStatus> {
862859
super.dispose();
863860
this._subscriptions = dispose(this._subscriptions);
864861
}
865-
}
862+
}

0 commit comments

Comments
 (0)