Move keyboard feature detection into caniuse.

rebornix · rebornix · commit bcede909b4fc · 2019-11-11T10:42:33.000-08:00
diff --git a/src/vs/base/browser/canIUse.ts b/src/vs/base/browser/canIUse.ts
@@ -6,6 +6,12 @@
 import * as browser from 'vs/base/browser/browser';
 import * as platform from 'vs/base/common/platform';
 
+export const enum KeyboardSupport {
+	Always,
+	FullScreen,
+	None
+}
+
 /**
  * Browser feature we can support in current platform, browser and environment.
  */
@@ -37,9 +43,17 @@ export const BrowserFeatures = {
 			return true;
 		})()
 	},
-	/*
-	 * Full Keyboard Support in Full Screen Mode or Standablone
-	 */
-	fullKeyboard: !!(<any>navigator).keyboard || browser.isSafari,
+	keyboard: (() => {
+		if (platform.isNative || browser.isStandalone) {
+			return KeyboardSupport.Always;
+		}
+
+		if ((<any>navigator).keyboard || browser.isSafari) {
+			return KeyboardSupport.FullScreen;
+		}
+
+		return KeyboardSupport.None;
+	})(),
+
 	touch: 'ontouchstart' in window || navigator.maxTouchPoints > 0 || window.navigator.msMaxTouchPoints > 0
 };
diff --git a/src/vs/workbench/services/clipboard/browser/clipboardService.ts b/src/vs/workbench/services/clipboard/browser/clipboardService.ts
@@ -27,6 +27,10 @@ export class BrowserClipboardService implements IClipboardService {
 			newTextarea.style.visibility = 'false';
 			newTextarea.style.height = '1px';
 			newTextarea.style.width = '1px';
+			newTextarea.setAttribute('aria-hidden', 'true');
+			newTextarea.style.position = 'absolute';
+			newTextarea.style.top = '-1000';
+			newTextarea.style.left = '-1000';
 			document.body.appendChild(newTextarea);
 			newTextarea.value = text;
 			newTextarea.focus();
diff --git a/src/vs/workbench/services/keybinding/browser/keybindingService.ts b/src/vs/workbench/services/keybinding/browser/keybindingService.ts
@@ -46,7 +46,7 @@ import { isArray } from 'vs/base/common/types';
 import { INavigatorWithKeyboard, IKeyboard } from 'vs/workbench/services/keybinding/browser/navigatorKeyboard';
 import { ScanCodeUtils, IMMUTABLE_CODE_TO_KEY_CODE } from 'vs/base/common/scanCode';
 import { flatten } from 'vs/base/common/arrays';
-import { BrowserFeatures } from 'vs/base/browser/canIUse';
+import { BrowserFeatures, KeyboardSupport } from 'vs/base/browser/canIUse';
 
 interface ContributedKeyBinding {
 	command: string;
@@ -241,7 +241,7 @@ export class WorkbenchKeybindingService extends AbstractKeybindingService {
 		this._register(browser.onDidChangeFullscreen(() => {
 			const keyboard: IKeyboard | null = (<INavigatorWithKeyboard>navigator).keyboard;
 
-			if (!BrowserFeatures.fullKeyboard) {
+			if (BrowserFeatures.keyboard === KeyboardSupport.None) {
 				return;
 			}
 
@@ -352,15 +352,11 @@ export class WorkbenchKeybindingService extends AbstractKeybindingService {
 	}
 
 	private _assertBrowserConflicts(kb: Keybinding, commandId: string): boolean {
-		if (!isWeb) {
+		if (BrowserFeatures.keyboard === KeyboardSupport.Always) {
 			return false;
 		}
 
-		if (browser.isStandalone) {
-			return false;
-		}
-
-		if (browser.isFullscreen() && BrowserFeatures.fullKeyboard) {
+		if (BrowserFeatures.keyboard === KeyboardSupport.FullScreen && browser.isFullscreen()) {
 			return false;
 		}
 
