debt: remove usages of deprecated startsWith util

sandy081 · sandy081 · commit bc110dba96c4 · 2020-07-08T09:30:46.000+02:00
diff --git a/src/vs/platform/userDataSync/common/extensionsMerge.ts b/src/vs/platform/userDataSync/common/extensionsMerge.ts
@@ -5,7 +5,6 @@
 
 import { ISyncExtension } from 'vs/platform/userDataSync/common/userDataSync';
 import { IExtensionIdentifier } from 'vs/platform/extensions/common/extensions';
-import { startsWith } from 'vs/base/common/strings';
 import { deepClone } from 'vs/base/common/objects';
 import { ILocalExtension } from 'vs/platform/extensionManagement/common/extensionManagement';
 import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
@@ -189,7 +188,7 @@ function massageOutgoingExtension(extension: ISyncExtension, key: string): ISync
 	const massagedExtension: ISyncExtension = {
 		identifier: {
 			id: extension.identifier.id,
-			uuid: startsWith(key, 'uuid:') ? key.substring('uuid:'.length) : undefined
+			uuid: key.startsWith('uuid:') ? key.substring('uuid:'.length) : undefined
 		},
 	};
 	if (extension.disabled) {
@@ -210,7 +209,7 @@ export function getIgnoredExtensions(installed: ILocalExtension[], configuration
 	const added: string[] = [], removed: string[] = [];
 	if (Array.isArray(value)) {
 		for (const key of value) {
-			if (startsWith(key, '-')) {
+			if (key.startsWith('-')) {
 				removed.push(key.substring(1));
 			} else {
 				added.push(key);
diff --git a/src/vs/platform/userDataSync/common/settingsMerge.ts b/src/vs/platform/userDataSync/common/settingsMerge.ts
@@ -12,7 +12,6 @@ import * as contentUtil from 'vs/platform/userDataSync/common/content';
 import { IConflictSetting, getDisallowedIgnoredSettings } from 'vs/platform/userDataSync/common/userDataSync';
 import { firstIndex, distinct } from 'vs/base/common/arrays';
 import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
-import { startsWith } from 'vs/base/common/strings';
 
 export interface IMergeResult {
 	localContent: string | null;
@@ -34,7 +33,7 @@ export function getIgnoredSettings(defaultIgnoredSettings: string[], configurati
 	const added: string[] = [], removed: string[] = [...getDisallowedIgnoredSettings()];
 	if (Array.isArray(value)) {
 		for (const key of value) {
-			if (startsWith(key, '-')) {
+			if (key.startsWith('-')) {
 				removed.push(key.substring(1));
 			} else {
 				added.push(key);
diff --git a/src/vs/workbench/contrib/markers/browser/markersFilterOptions.ts b/src/vs/workbench/contrib/markers/browser/markersFilterOptions.ts
@@ -34,7 +34,7 @@ export class FilterOptions {
 		if (filter) {
 			const filters = splitGlobAware(filter, ',').map(s => s.trim()).filter(s => !!s.length);
 			for (const f of filters) {
-				if (strings.startsWith(f, '!')) {
+				if (f.startsWith('!')) {
 					this.setPattern(excludesExpression, strings.ltrim(f, '!'));
 				} else {
 					this.setPattern(includeExpression, f);
diff --git a/src/vs/workbench/services/userData/common/fileUserDataProvider.ts b/src/vs/workbench/services/userData/common/fileUserDataProvider.ts
@@ -7,7 +7,6 @@ import { Event, Emitter } from 'vs/base/common/event';
 import { Disposable, IDisposable } from 'vs/base/common/lifecycle';
 import { IFileSystemProviderWithFileReadWriteCapability, IFileChange, IWatchOptions, IStat, FileOverwriteOptions, FileType, FileWriteOptions, FileDeleteOptions, FileSystemProviderCapabilities, IFileSystemProviderWithOpenReadWriteCloseCapability, FileOpenOptions, hasReadWriteCapability, hasOpenReadWriteCloseCapability, IFileSystemProviderWithFileReadStreamCapability, FileReadStreamOptions, hasFileReadStreamCapability } from 'vs/platform/files/common/files';
 import { URI } from 'vs/base/common/uri';
-import { startsWith } from 'vs/base/common/strings';
 import { BACKUPS } from 'vs/platform/environment/common/environment';
 import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService';
 import { CancellationToken } from 'vs/base/common/cancellation';
@@ -141,7 +140,7 @@ export class FileUserDataProvider extends Disposable implements
 
 	private toFileSystemResource(userDataResource: URI): URI {
 		const relativePath = this.extUri.relativePath(this.userDataHome, userDataResource)!;
-		if (startsWith(relativePath, BACKUPS)) {
+		if (relativePath.startsWith(BACKUPS)) {
 			return this.extUri.joinPath(this.extUri.dirname(this.fileSystemBackupsHome), relativePath);
 		}
 		return this.extUri.joinPath(this.fileSystemUserDataHome, relativePath);
