fix vscode.open() tests (microsoft#81833)

Benjamin Pasero · web-flow · commit bb0dbb3b9c8f · 2019-10-02T12:28:48.000+02:00
diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/commands.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/commands.test.ts
@@ -104,13 +104,13 @@ suite('commands namespace tests', () => {
 		return Promise.all([a, b, c, d, e]);
 	});
 
-	// test('api-command: vscode.open', function () {
-	// 	let uri = Uri.parse(workspace.workspaceFolders![0].uri.toString() + '/image.png');
-	// 	let a = commands.executeCommand('vscode.open', uri).then(() => assert.ok(true), () => assert.ok(false));
-	// 	let b = commands.executeCommand('vscode.open', uri, ViewColumn.Two).then(() => assert.ok(true), () => assert.ok(false));
-	// 	let c = commands.executeCommand('vscode.open').then(() => assert.ok(false), () => assert.ok(true));
-	// 	let d = commands.executeCommand('vscode.open', uri, true).then(() => assert.ok(false), () => assert.ok(true));
-
-	// 	return Promise.all([a, b, c, d]);
-	// });
+	test('api-command: vscode.open', function () {
+		let uri = Uri.parse(workspace.workspaceFolders![0].uri.toString() + '/image.png');
+		let a = commands.executeCommand('vscode.open', uri).then(() => assert.ok(true), () => assert.ok(false));
+		let b = commands.executeCommand('vscode.open', uri, ViewColumn.Two).then(() => assert.ok(true), () => assert.ok(false));
+		let c = commands.executeCommand('vscode.open').then(() => assert.ok(false), () => assert.ok(true));
+		let d = commands.executeCommand('vscode.open', uri, true).then(() => assert.ok(false), () => assert.ok(true));
+
+		return Promise.all([a, b, c, d]);
+	});
 });
diff --git a/scripts/test-integration.bat b/scripts/test-integration.bat
@@ -20,6 +20,7 @@ if "%INTEGRATION_TEST_ELECTRON_PATH%"=="" (
 	call yarn gulp compile-extension:css-language-features-server
 	call yarn gulp compile-extension:html-language-features-server
 	call yarn gulp compile-extension:json-language-features-server
+	call yarn gulp compile-extension:image-preview
 
 	echo "Running integration tests with '%INTEGRATION_TEST_ELECTRON_PATH%' as build."
 )
diff --git a/scripts/test-integration.sh b/scripts/test-integration.sh
@@ -29,6 +29,7 @@ else
 	yarn gulp compile-extension:css-language-features-server
 	yarn gulp compile-extension:html-language-features-server
 	yarn gulp compile-extension:json-language-features-server
+	yarn gulp compile-extension:image-preview
 
 	echo "Running integration tests with '$INTEGRATION_TEST_ELECTRON_PATH' as build."
 fi

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ if "%INTEGRATION_TEST_ELECTRON_PATH%"=="" (`
`20`	`20`	`call yarn gulp compile-extension:css-language-features-server`
`21`	`21`	`call yarn gulp compile-extension:html-language-features-server`
`22`	`22`	`call yarn gulp compile-extension:json-language-features-server`
	`23`	`+ call yarn gulp compile-extension:image-preview`
`23`	`24`
`24`	`25`	`echo "Running integration tests with '%INTEGRATION_TEST_ELECTRON_PATH%' as build."`
`25`	`26`	`)`