cleanup more promises

joaomoreno · joaomoreno · commit ba7b1cb0d5b2 · 2018-07-02T16:49:11.000+02:00
related to microsoft#53442
diff --git a/src/vs/code/electron-main/main.ts b/src/vs/code/electron-main/main.ts
@@ -81,7 +81,7 @@ function createServices(args: ParsedArgs, bufferLogService: BufferLogService): I
 /**
  * Cleans up older logs, while keeping the 10 most recent ones.
 */
-async function cleanupOlderLogs(environmentService: EnvironmentService): TPromise<void> {
+async function cleanupOlderLogs(environmentService: EnvironmentService): Promise<void> {
 	const currentLog = path.basename(environmentService.logsPath);
 	const logsRoot = path.dirname(environmentService.logsPath);
 	const children = await readdir(logsRoot);
diff --git a/src/vs/code/node/cli.ts b/src/vs/code/node/cli.ts
@@ -31,7 +31,7 @@ interface IMainCli {
 	main: (argv: ParsedArgs) => TPromise<void>;
 }
 
-export async function main(argv: string[]): TPromise<any> {
+export async function main(argv: string[]): Promise<any> {
 	let args: ParsedArgs;
 
 	try {
diff --git a/src/vs/code/node/cliProcessMain.ts b/src/vs/code/node/cliProcessMain.ts
@@ -181,7 +181,7 @@ class Main {
 	}
 
 	private uninstallExtension(extensions: string[]): TPromise<any> {
-		async function getExtensionId(extensionDescription: string): TPromise<string> {
+		async function getExtensionId(extensionDescription: string): Promise<string> {
 			if (!/\.vsix$/i.test(extensionDescription)) {
 				return extensionDescription;
 			}
diff --git a/src/vs/platform/extensionManagement/node/extensionManagementService.ts b/src/vs/platform/extensionManagement/node/extensionManagementService.ts
@@ -687,7 +687,7 @@ export class ExtensionManagementService extends Disposable implements IExtension
 		return promise;
 	}
 
-	private async postUninstallExtension(extension: ILocalExtension, error?: Error): TPromise<void> {
+	private async postUninstallExtension(extension: ILocalExtension, error?: Error): Promise<void> {
 		if (error) {
 			this.logService.error('Failed to uninstall extension:', extension.identifier.id, error.message);
 		} else {
diff --git a/src/vs/platform/request/node/requestService.ts b/src/vs/platform/request/node/requestService.ts
@@ -40,18 +40,21 @@ export class RequestService implements IRequestService {
 		this.authorization = config.http && config.http.proxyAuthorization;
 	}
 
-	async request(options: IRequestOptions, requestFn: IRequestFunction = request): TPromise<IRequestContext> {
+	request(options: IRequestOptions, requestFn: IRequestFunction = request): TPromise<IRequestContext> {
 		this.logService.trace('RequestService#request', options.url);
 
 		const { proxyUrl, strictSSL } = this;
+		const agentPromise = options.agent ? TPromise.wrap(options.agent) : TPromise.wrap(getProxyAgent(options.url, { proxyUrl, strictSSL }));
 
-		options.agent = options.agent || await getProxyAgent(options.url, { proxyUrl, strictSSL });
-		options.strictSSL = strictSSL;
+		return agentPromise.then(agent => {
+			options.agent = agent;
+			options.strictSSL = strictSSL;
 
-		if (this.authorization) {
-			options.headers = assign(options.headers || {}, { 'Proxy-Authorization': this.authorization });
-		}
+			if (this.authorization) {
+				options.headers = assign(options.headers || {}, { 'Proxy-Authorization': this.authorization });
+			}
 
-		return requestFn(options);
+			return requestFn(options);
+		});
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ interface IMainCli {`
`31`	`31`	`main: (argv: ParsedArgs) => TPromise<void>;`
`32`	`32`	`}`
`33`	`33`
`34`		`-export async function main(argv: string[]): TPromise<any> {`
	`34`	`+export async function main(argv: string[]): Promise<any> {`
`35`	`35`	`let args: ParsedArgs;`
`36`	`36`
`37`	`37`	`try {`
Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ class Main {`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`private uninstallExtension(extensions: string[]): TPromise<any> {`
`184`		`- async function getExtensionId(extensionDescription: string): TPromise<string> {`
	`184`	`+ async function getExtensionId(extensionDescription: string): Promise<string> {`
`185`	`185`	`if (!/\.vsix$/i.test(extensionDescription)) {`
`186`	`186`	`return extensionDescription;`
`187`	`187`	`}`
Original file line number	Diff line number	Diff line change
`@@ -687,7 +687,7 @@ export class ExtensionManagementService extends Disposable implements IExtension`
`687`	`687`	`return promise;`
`688`	`688`	`}`
`689`	`689`
`690`		`- private async postUninstallExtension(extension: ILocalExtension, error?: Error): TPromise<void> {`
	`690`	`+ private async postUninstallExtension(extension: ILocalExtension, error?: Error): Promise<void> {`
`691`	`691`	`if (error) {`
`692`	`692`	`this.logService.error('Failed to uninstall extension:', extension.identifier.id, error.message);`
`693`	`693`	`} else {`