Add hasChangelog method to display the tab eventually

XVincentX · XVincentX · commit b98c3f7d79bb · 2016-09-15T09:54:48.000+02:00
diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts
@@ -254,7 +254,10 @@ export class ExtensionEditor extends BaseEditor {
 		this.navbar.onChange(this.onNavbarChange.bind(this, extension), this, this.transientDisposables);
 		this.navbar.push(NavbarSection.Readme, localize('details', "Details"));
 		this.navbar.push(NavbarSection.Contributions, localize('contributions', "Contributions"));
-		this.navbar.push(NavbarSection.Changelog, localize('changelog', "Changelog"));
+
+		if (extension.hasChangelog) {
+			this.navbar.push(NavbarSection.Changelog, localize('changelog', "Changelog"));
+		}
 
 		this.content.innerHTML = '';
 
diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensions.ts b/src/vs/workbench/parts/extensions/electron-browser/extensions.ts
@@ -42,6 +42,7 @@ export interface IExtension {
 	telemetryData: any;
 	getManifest(): TPromise<IExtensionManifest>;
 	getReadme(): TPromise<string>;
+	hasChangelog : boolean;
 	getChangelog() : TPromise<string>;
 }
 
diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts
@@ -187,6 +187,10 @@ class Extension implements IExtension {
 		return this.galleryService.getAsset(readmeUrl).then(asText);
 	}
 
+	get hasChangelog() : boolean {
+		return !!(this.local && this.local.changelogUrl ? this.local.changelogUrl : '');
+	}
+
 	getChangelog() : TPromise<string> {
 		const changelogUrl = this.local && this.local.changelogUrl ? this.local.changelogUrl : '';
 

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,7 @@ export interface IExtension {`
`42`	`42`	`telemetryData: any;`
`43`	`43`	`getManifest(): TPromise<IExtensionManifest>;`
`44`	`44`	`getReadme(): TPromise<string>;`
	`45`	`+ hasChangelog : boolean;`
`45`	`46`	`getChangelog() : TPromise<string>;`
`46`	`47`	`}`
`47`	`48`
Original file line number	Diff line number	Diff line change
`@@ -187,6 +187,10 @@ class Extension implements IExtension {`
`187`	`187`	`return this.galleryService.getAsset(readmeUrl).then(asText);`
`188`	`188`	`}`
`189`	`189`
	`190`	`+ get hasChangelog() : boolean {`
	`191`	`+ return !!(this.local && this.local.changelogUrl ? this.local.changelogUrl : '');`
	`192`	`+ }`
	`193`	`+`
`190`	`194`	`getChangelog() : TPromise<string> {`
`191`	`195`	`const changelogUrl = this.local && this.local.changelogUrl ? this.local.changelogUrl : '';`
`192`	`196`