foxes microsoft#4648: [codelens] Uncaught TypeError: Cannot read property 'symbol' of undefined

aeschli · aeschli · commit b6fdf0943ed3 · 2016-04-01T14:38:48.000+02:00
diff --git a/src/vs/editor/contrib/codelens/browser/codelens.ts b/src/vs/editor/contrib/codelens/browser/codelens.ts
@@ -279,8 +279,18 @@ class CodeLens {
 		});
 	}
 
-	public updateCodeLensSymbols(data: ICodeLensData[]): void {
+	public updateCodeLensSymbols(data: ICodeLensData[], helper: CodeLensHelper): void {
+		while (this._decorationIds.length) {
+			helper.removeDecoration(this._decorationIds.pop());
+		}
 		this._data = data;
+		this._decorationIds = new Array<string>(this._data.length);
+		this._data.forEach((codeLensData, i) => {
+			helper.addDecoration({
+				range: codeLensData.symbol.range,
+				options: {}
+			}, id => this._decorationIds[i] = id);
+		});
 	}
 
 	public computeIfNecessary(currentModelsVersionId: number, model: editorCommon.IModel): ICodeLensData[] {
@@ -556,7 +566,7 @@ export class CodeLensContribution implements editorCommon.IEditorContribution {
 						this._lenses[codeLensIndex].dispose(helper, accessor);
 						this._lenses.splice(codeLensIndex, 1);
 					} else if (codeLensLineNumber === symbolsLineNumber) {
-						this._lenses[codeLensIndex].updateCodeLensSymbols(groups[groupsIndex]);
+						this._lenses[codeLensIndex].updateCodeLensSymbols(groups[groupsIndex], helper);
 						groupsIndex++;
 						codeLensIndex++;
 					} else {
