Validate before deserialization

Jackson Kearl · Jackson Kearl · commit b60f43d09824 · 2020-01-23T14:52:10.000-08:00
diff --git a/src/vs/workbench/contrib/search/browser/searchEditorInput.ts b/src/vs/workbench/contrib/search/browser/searchEditorInput.ts
@@ -254,10 +254,12 @@ export class SearchEditorInputFactory implements IEditorInputFactory {
 
 	deserialize(instantiationService: IInstantiationService, serializedEditorInput: string): SearchEditorInput | undefined {
 		const { resource, dirty, config } = JSON.parse(serializedEditorInput);
-
-		const input = instantiationService.invokeFunction(getOrMakeSearchEditorInput, { text: serializeSearchConfiguration(config), uri: URI.parse(resource) });
-		input.setDirty(dirty);
-		return input;
+		if (config && (config.query !== undefined)) {
+			const input = instantiationService.invokeFunction(getOrMakeSearchEditorInput, { text: serializeSearchConfiguration(config), uri: URI.parse(resource) });
+			input.setDirty(dirty);
+			return input;
+		}
+		return undefined;
 	}
 }
 
