Extract constant

mjbvz · mjbvz · commit b46b5251ae0d · 2020-06-22T15:02:52.000-07:00
diff --git a/src/vs/editor/contrib/codeAction/codeAction.ts b/src/vs/editor/contrib/codeAction/codeAction.ts
@@ -73,6 +73,9 @@ class ManagedCodeActionSet extends Disposable implements CodeActionSet {
 	}
 }
 
+
+const emptyCodeActionsResponse = { actions: [] as modes.CodeAction[], documentation: undefined };
+
 export function getCodeActions(
 	model: ITextModel,
 	rangeOrSelection: Range | Selection,
@@ -100,7 +103,7 @@ export function getCodeActions(
 			}
 
 			if (cts.token.isCancellationRequested) {
-				return { actions: [] as modes.CodeAction[], documentation: undefined };
+				return emptyCodeActionsResponse;
 			}
 
 			const filteredActions = (providedCodeActions?.actions || []).filter(action => action && filtersAction(filter, action));
@@ -111,7 +114,7 @@ export function getCodeActions(
 				throw err;
 			}
 			onUnexpectedExternalError(err);
-			return { actions: [] as modes.CodeAction[], documentation: undefined };
+			return emptyCodeActionsResponse;
 		}
 	});
 

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,9 @@ class ManagedCodeActionSet extends Disposable implements CodeActionSet {`
`73`	`73`	`}`
`74`	`74`	`}`
`75`	`75`
	`76`	`+`
	`77`	`+const emptyCodeActionsResponse = { actions: [] as modes.CodeAction[], documentation: undefined };`
	`78`	`+`
`76`	`79`	`export function getCodeActions(`
`77`	`80`	`model: ITextModel,`
`78`	`81`	`rangeOrSelection: Range \| Selection,`
`@@ -100,7 +103,7 @@ export function getCodeActions(`
`100`	`103`	`}`
`101`	`104`
`102`	`105`	`if (cts.token.isCancellationRequested) {`
`103`		`- return { actions: [] as modes.CodeAction[], documentation: undefined };`
	`106`	`+ return emptyCodeActionsResponse;`
`104`	`107`	`}`
`105`	`108`
`106`	`109`	`const filteredActions = (providedCodeActions?.actions \|\| []).filter(action => action && filtersAction(filter, action));`
`@@ -111,7 +114,7 @@ export function getCodeActions(`
`111`	`114`	`throw err;`
`112`	`115`	`}`
`113`	`116`	`onUnexpectedExternalError(err);`
`114`		`- return { actions: [] as modes.CodeAction[], documentation: undefined };`
	`117`	`+ return emptyCodeActionsResponse;`
`115`	`118`	`}`
`116`	`119`	`});`
`117`	`120`