Add fix to non-externalized string warning

egamma · egamma · commit b381829341ca · 2016-12-01T10:08:11.000+01:00
diff --git a/build/lib/tslint/noUnexternalizedStringsRule.js b/build/lib/tslint/noUnexternalizedStringsRule.js
@@ -89,8 +89,12 @@ var NoUnexternalizedStringsRuleWalker = (function (_super) {
         if (functionName && this.ignores[functionName]) {
             return;
         }
+        var x = "foo";
         if (doubleQuoted && (!callInfo || callInfo.argIndex === -1 || !this.signatures[functionName])) {
-            this.addFailure(this.createFailure(node.getStart(), node.getWidth(), "Unexternalized string found: " + node.getText()));
+            var s = node.getText();
+            var replacement = new Lint.Replacement(node.getStart(), node.getWidth(), "nls.localize('KEY-" + s.substring(1, s.length - 1) + "', " + s + ")");
+            var fix = new Lint.Fix("Unexternalitzed string", [replacement]);
+            this.addFailure(this.createFailure(node.getStart(), node.getWidth(), "Unexternalized string found: " + node.getText(), fix));
             return;
         }
         // We have a single quoted string outside a localize function name.
@@ -109,8 +113,8 @@ var NoUnexternalizedStringsRuleWalker = (function (_super) {
                 for (var i = 0; i < keyArg.properties.length; i++) {
                     var property = keyArg.properties[i];
                     if (isPropertyAssignment(property)) {
-                        var name_1 = property.name.getText();
-                        if (name_1 === 'key') {
+                        var name = property.name.getText();
+                        if (name === 'key') {
                             var initializer = property.initializer;
                             if (isStringLiteral(initializer)) {
                                 this.recordKey(initializer, this.messageIndex ? callInfo.callExpression.arguments[this.messageIndex] : undefined);
diff --git a/build/lib/tslint/noUnexternalizedStringsRule.ts b/build/lib/tslint/noUnexternalizedStringsRule.ts
@@ -109,8 +109,12 @@ class NoUnexternalizedStringsRuleWalker extends Lint.RuleWalker {
 		if (functionName && this.ignores[functionName]) {
 			return;
 		}
+
 		if (doubleQuoted && (!callInfo || callInfo.argIndex === -1 || !this.signatures[functionName])) {
-			this.addFailure(this.createFailure(node.getStart(), node.getWidth(), `Unexternalized string found: ${node.getText()}`));
+			const s = node.getText();
+			const replacement = new Lint.Replacement(node.getStart(), node.getWidth(), `nls.localize('KEY-${s.substring(1, s.length - 1)}', ${s})`);
+			const fix = new Lint.Fix("Unexternalitzed string", [replacement]);
+			this.addFailure(this.createFailure(node.getStart(), node.getWidth(), `Unexternalized string found: ${node.getText()}`, fix));
 			return;
 		}
 		// We have a single quoted string outside a localize function name.

Original file line number	Diff line number	Diff line change
`@@ -109,8 +109,12 @@ class NoUnexternalizedStringsRuleWalker extends Lint.RuleWalker {`
`109`	`109`	`if (functionName && this.ignores[functionName]) {`
`110`	`110`	`return;`
`111`	`111`	`}`
	`112`	`+`
`112`	`113`	`if (doubleQuoted && (!callInfo \|\| callInfo.argIndex === -1 \|\| !this.signatures[functionName])) {`
`113`		- this.addFailure(this.createFailure(node.getStart(), node.getWidth(), `Unexternalized string found: ${node.getText()}`));
	`114`	`+ const s = node.getText();`
	`115`	+ const replacement = new Lint.Replacement(node.getStart(), node.getWidth(), `nls.localize('KEY-${s.substring(1, s.length - 1)}', ${s})`);
	`116`	`+ const fix = new Lint.Fix("Unexternalitzed string", [replacement]);`
	`117`	+ this.addFailure(this.createFailure(node.getStart(), node.getWidth(), `Unexternalized string found: ${node.getText()}`, fix));
`114`	`118`	`return;`
`115`	`119`	`}`
`116`	`120`	`// We have a single quoted string outside a localize function name.`