Skip to content

Commit b35d879

Browse files
jriekenjrieken
committed
update v8 profiler package
1 parent 3a08ae6 commit b35d879

4 files changed

Lines changed: 32 additions & 22 deletions

File tree

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"semver": "^5.5.0",
4646
"spdlog": "0.7.2",
4747
"sudo-prompt": "8.2.0",
48-
"v8-inspect-profiler": "^0.0.8",
48+
"v8-inspect-profiler": "^0.0.13",
4949
"vscode-chokidar": "1.6.5",
5050
"vscode-debugprotocol": "1.32.0",
5151
"vscode-nsfw": "1.1.1",

‎src/typings/v8-inspect-profiler.d.ts‎

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,17 @@ declare module 'v8-inspect-profiler' {
3131
stop(afterDelay?: number): PromiseLike<ProfileResult>;
3232
}
3333

34-
export function startProfiling(options: { port: number, tries?: number, retyWait?: number }): PromiseLike<ProfilingSession>;
34+
export interface Target {
35+
description: string,
36+
devtoolsFrontendUrl: string,
37+
id: string,
38+
title: string,
39+
type: string,
40+
url: string,
41+
webSocketDebuggerUrl: string
42+
}
43+
44+
export function startProfiling(options: { port: number, tries?: number, retyWait?: number, target?: (targets: Target[]) => Target }): PromiseLike<ProfilingSession>;
3545
export function writeProfile(profile: ProfileResult, name?: string): PromiseLike<void>;
36-
export function rewriteAbsolutePaths(profile, replaceWith?);
46+
export function rewriteAbsolutePaths(profile: ProfileResult, replaceWith?: string): ProfileResult;
3747
}

‎src/vs/code/node/cli.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { resolveTerminalEncoding } from 'vs/base/node/encoding';
1919
import * as iconv from 'iconv-lite';
2020
import { writeFileAndFlushSync } from 'vs/base/node/extfs';
2121
import { isWindows } from 'vs/base/common/platform';
22-
import { ProfilingSession } from 'v8-inspect-profiler';
22+
import { ProfilingSession, Target } from 'v8-inspect-profiler';
2323
import { createWaitMarkerFile } from 'vs/code/node/wait';
2424

2525
function shouldSpawnCliProcess(argv: ParsedArgs): boolean {
@@ -262,7 +262,7 @@ export async function main(argv: string[]): Promise<any> {
262262
processCallbacks.push(async _child => {
263263

264264
class Profiler {
265-
static async start(name: string, filenamePrefix: string, opts: { port: number, tries?: number, chooseTab?: Function }) {
265+
static async start(name: string, filenamePrefix: string, opts: { port: number, tries?: number, target?: (targets: Target[]) => Target }) {
266266
const profiler = await import('v8-inspect-profiler');
267267

268268
let session: ProfilingSession;
@@ -301,8 +301,8 @@ export async function main(argv: string[]): Promise<any> {
301301
const rendererProfileRequest = Profiler.start('renderer', filenamePrefix, {
302302
port: portRenderer,
303303
tries: 200,
304-
chooseTab: function (targets) {
305-
return targets.find(target => {
304+
target: function (targets) {
305+
return targets.filter(target => {
306306
if (!target.webSocketDebuggerUrl) {
307307
return false;
308308
}
@@ -311,7 +311,7 @@ export async function main(argv: string[]): Promise<any> {
311311
} else {
312312
return true;
313313
}
314-
});
314+
})[0];
315315
}
316316
});
317317

‎yarn.lock‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1260,13 +1260,13 @@ chownr@^1.0.1:
12601260
resolved "https://registry.yarnpkg.com/chownr/-/chownr-1.0.1.tgz#e2a75042a9551908bebd25b8523d5f9769d79181"
12611261
integrity sha1-4qdQQqlVGQi+vSW4Uj1fl2nXkYE=
12621262

1263-
chrome-remote-interface@^0.25.3:
1264-
version "0.25.3"
1265-
resolved "https://registry.yarnpkg.com/chrome-remote-interface/-/chrome-remote-interface-0.25.3.tgz#b692ae538cd5af3a6dd285636bfab3d29a7006c1"
1266-
integrity sha512-+GJLyocWojJbo9ODkRGKkMA/jMgzVZtCUOpYSeVXYlPTWkcjUqsV4PeTgLWbzRy8TIRj69xYm0Gcy2Oo07AkYA==
1263+
chrome-remote-interface@^0.26.1:
1264+
version "0.26.1"
1265+
resolved "https://registry.yarnpkg.com/chrome-remote-interface/-/chrome-remote-interface-0.26.1.tgz#6c7d4479742b6d236752d716a9bc2d322d7d8ad2"
1266+
integrity sha512-ela482aJK0riFu05sl+zdbnb3ezMiqzwsqf/f/27HngWds+Fat3vcZWpIoDoeQuWMid/+LfKAteAYWaWPqsweg==
12671267
dependencies:
12681268
commander "2.11.x"
1269-
ws "3.3.x"
1269+
ws "^3.3.3"
12701270

12711271
chrome-trace-event@^1.0.0:
12721272
version "1.0.0"
@@ -9059,12 +9059,12 @@ v8-compile-cache@^2.0.0:
90599059
resolved "https://registry.yarnpkg.com/v8-compile-cache/-/v8-compile-cache-2.0.2.tgz#a428b28bb26790734c4fc8bc9fa106fccebf6a6c"
90609060
integrity sha512-1wFuMUIM16MDJRCrpbpuEPTUGmM5QMUg0cr3KFwra2XgOgFcPGDQHDh3CszSCD2Zewc/dh/pamNEW8CbfDebUw==
90619061

9062-
v8-inspect-profiler@^0.0.8:
9063-
version "0.0.8"
9064-
resolved "https://registry.yarnpkg.com/v8-inspect-profiler/-/v8-inspect-profiler-0.0.8.tgz#4d6bedb7c3d1bfc69e5bfdc2ded3d6784a5a76a6"
9065-
integrity sha1-TWvtt8PRv8aeW/3C3tPWeEpadqY=
9062+
v8-inspect-profiler@^0.0.13:
9063+
version "0.0.13"
9064+
resolved "https://registry.yarnpkg.com/v8-inspect-profiler/-/v8-inspect-profiler-0.0.13.tgz#4bf4e7d51a9df8ac6f9a1df5487a636cf4ec2c5a"
9065+
integrity sha512-t6EldtIyV35/AkwFH40Dikhv9ZzySdjFPdnhVlNR4EWA0cVvOXnr1djc35HhG57yFdbFGRb8A2cxAFuccc1uxw==
90669066
dependencies:
9067-
chrome-remote-interface "^0.25.3"
9067+
chrome-remote-interface "^0.26.1"
90689068

90699069
v8flags@^2.0.2:
90709070
version "2.1.1"
@@ -9584,10 +9584,10 @@ write@^0.2.1:
95849584
dependencies:
95859585
mkdirp "^0.5.1"
95869586

9587-
ws@3.3.x:
9588-
version "3.3.2"
9589-
resolved "https://registry.yarnpkg.com/ws/-/ws-3.3.2.tgz#96c1d08b3fefda1d5c1e33700d3bfaa9be2d5608"
9590-
integrity sha512-t+WGpsNxhMR4v6EClXS8r8km5ZljKJzyGhJf7goJz9k5Ye3+b5Bvno5rjqPuIBn5mnn5GBb7o8IrIWHxX1qOLQ==
9587+
ws@^3.3.3:
9588+
version "3.3.3"
9589+
resolved "https://registry.yarnpkg.com/ws/-/ws-3.3.3.tgz#f1cf84fe2d5e901ebce94efaece785f187a228f2"
9590+
integrity sha512-nnWLa/NwZSt4KQJu51MYlCcSQ5g7INpOrOMt4XV8j4dqTXdmlUmSHQ8/oLC069ckre0fRsgfvsKwbTdtKLCDkA==
95919591
dependencies:
95929592
async-limiter "~1.0.0"
95939593
safe-buffer "~5.1.0"

0 commit comments

Comments
 (0)