Sanity check lines[y] to fix exception

Tyriar · Tyriar · commit b2b71a8296ea · 2020-08-26T06:50:45.000-07:00
Fixes microsoft#105333
diff --git a/src/vs/workbench/contrib/terminal/browser/links/terminalLinkHelpers.ts b/src/vs/workbench/contrib/terminal/browser/links/terminalLinkHelpers.ts
@@ -54,6 +54,12 @@ export function convertLinkRangeToBuffer(lines: IBufferLine[], bufferWidth: numb
 		const startLineOffset = (y === startWrappedLineCount - 1 ? startOffset : 0);
 		let lineOffset = 0;
 		const line = lines[y];
+		// Sanity check for line, apparently this can happen but it's not clear under what
+		// circumstances this happens. Continue on, skipping the remainder of start offset if this
+		// happens to minimize impact.
+		if (!line) {
+			break;
+		}
 		for (let x = start; x < Math.min(bufferWidth, lineLength + lineOffset + startLineOffset); x++) {
 			const cell = line.getCell(x)!;
 			const width = cell.getWidth();
