Skip to content

Commit b293be4

Browse files
TyriarTyriar
committed
Remove web links addon
1 parent 9a7a2dd commit b293be4

4 files changed

Lines changed: 0 additions & 24 deletions

File tree

‎src/vs/workbench/contrib/terminal/browser/terminal.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import { Terminal as XTermTerminal } from 'xterm';
77
import { SearchAddon as XTermSearchAddon } from 'xterm-addon-search';
88
import { Unicode11Addon as XTermUnicode11Addon } from 'xterm-addon-unicode11';
9-
import { WebLinksAddon as XTermWebLinksAddon } from 'xterm-addon-web-links';
109
import { WebglAddon as XTermWebglAddon } from 'xterm-addon-webgl';
1110
import { IWindowsShellHelper, ITerminalConfigHelper, ITerminalChildProcess, IShellLaunchConfig, IDefaultShellAndArgsRequest, ISpawnExtHostProcessRequest, IStartExtensionTerminalRequest, IAvailableShellsRequest, ITerminalProcessExtHostProxy, ICommandTracker, INavigationMode, TitleEventSource, ITerminalDimensions } from 'vs/workbench/contrib/terminal/common/terminal';
1211
import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
@@ -33,7 +32,6 @@ export interface ITerminalInstanceService {
3332
getXtermConstructor(): Promise<typeof XTermTerminal>;
3433
getXtermSearchConstructor(): Promise<typeof XTermSearchAddon>;
3534
getXtermUnicode11Constructor(): Promise<typeof XTermUnicode11Addon>;
36-
getXtermWebLinksConstructor(): Promise<typeof XTermWebLinksAddon>;
3735
getXtermWebglConstructor(): Promise<typeof XTermWebglAddon>;
3836
createWindowsShellHelper(shellProcessId: number, xterm: XTermTerminal): IWindowsShellHelper;
3937
createTerminalProcess(shellLaunchConfig: IShellLaunchConfig, cwd: string, cols: number, rows: number, env: IProcessEnvironment, windowsEnableConpty: boolean): ITerminalChildProcess;

‎src/vs/workbench/contrib/terminal/browser/terminalInstanceService.ts‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import { IWindowsShellHelper, ITerminalChildProcess, IDefaultShellAndArgsRequest
88
import { Terminal as XTermTerminal } from 'xterm';
99
import { SearchAddon as XTermSearchAddon } from 'xterm-addon-search';
1010
import { Unicode11Addon as XTermUnicode11Addon } from 'xterm-addon-unicode11';
11-
import { WebLinksAddon as XTermWebLinksAddon } from 'xterm-addon-web-links';
1211
import { WebglAddon as XTermWebglAddon } from 'xterm-addon-webgl';
1312
import { IProcessEnvironment } from 'vs/base/common/platform';
1413
import { Emitter, Event } from 'vs/base/common/event';
@@ -17,7 +16,6 @@ import { registerSingleton } from 'vs/platform/instantiation/common/extensions';
1716
let Terminal: typeof XTermTerminal;
1817
let SearchAddon: typeof XTermSearchAddon;
1918
let Unicode11Addon: typeof XTermUnicode11Addon;
20-
let WebLinksAddon: typeof XTermWebLinksAddon;
2119
let WebglAddon: typeof XTermWebglAddon;
2220

2321
export class TerminalInstanceService implements ITerminalInstanceService {
@@ -47,13 +45,6 @@ export class TerminalInstanceService implements ITerminalInstanceService {
4745
return Unicode11Addon;
4846
}
4947

50-
public async getXtermWebLinksConstructor(): Promise<typeof XTermWebLinksAddon> {
51-
if (!WebLinksAddon) {
52-
WebLinksAddon = (await import('xterm-addon-web-links')).WebLinksAddon;
53-
}
54-
return WebLinksAddon;
55-
}
56-
5748
public async getXtermWebglConstructor(): Promise<typeof XTermWebglAddon> {
5849
if (!WebglAddon) {
5950
WebglAddon = (await import('xterm-addon-webgl')).WebglAddon;

‎src/vs/workbench/contrib/terminal/electron-browser/terminalInstanceService.ts‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import { getSystemShell } from 'vs/workbench/contrib/terminal/node/terminal';
1313
import { Terminal as XTermTerminal } from 'xterm';
1414
import { SearchAddon as XTermSearchAddon } from 'xterm-addon-search';
1515
import { Unicode11Addon as XTermUnicode11Addon } from 'xterm-addon-unicode11';
16-
import { WebLinksAddon as XTermWebLinksAddon } from 'xterm-addon-web-links';
1716
import { WebglAddon as XTermWebglAddon } from 'xterm-addon-webgl';
1817
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
1918
import { getDefaultShell, getDefaultShellArgs } from 'vs/workbench/contrib/terminal/common/terminalEnvironment';
@@ -27,7 +26,6 @@ import { ILogService } from 'vs/platform/log/common/log';
2726
let Terminal: typeof XTermTerminal;
2827
let SearchAddon: typeof XTermSearchAddon;
2928
let Unicode11Addon: typeof XTermUnicode11Addon;
30-
let WebLinksAddon: typeof XTermWebLinksAddon;
3129
let WebglAddon: typeof XTermWebglAddon;
3230

3331
export class TerminalInstanceService implements ITerminalInstanceService {
@@ -51,13 +49,6 @@ export class TerminalInstanceService implements ITerminalInstanceService {
5149
return Terminal;
5250
}
5351

54-
public async getXtermWebLinksConstructor(): Promise<typeof XTermWebLinksAddon> {
55-
if (!WebLinksAddon) {
56-
WebLinksAddon = (await import('xterm-addon-web-links')).WebLinksAddon;
57-
}
58-
return WebLinksAddon;
59-
}
60-
6152
public async getXtermSearchConstructor(): Promise<typeof XTermSearchAddon> {
6253
if (!SearchAddon) {
6354
SearchAddon = (await import('xterm-addon-search')).SearchAddon;

‎src/vs/workbench/contrib/terminal/test/browser/links/terminalLinkManager.test.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,6 @@ class MockTerminalInstanceService implements ITerminalInstanceService {
4747
getXtermUnicode11Constructor(): Promise<any> {
4848
throw new Error('Method not implemented.');
4949
}
50-
// TODO: Remove this from the interface
51-
async getXtermWebLinksConstructor(): Promise<any> {
52-
// return (await import('xterm-addon-web-links')).WebLinksAddon;
53-
}
5450
getXtermWebglConstructor(): Promise<any> {
5551
throw new Error('Method not implemented.');
5652
}

0 commit comments

Comments
 (0)