Merge pull request microsoft#13774 from daserge:epipe-process-send

alexdima · alexdima · commit b10c51b0857a · 2016-10-24T20:03:13.000+02:00
Avoiding "write EPIPE process.send" error on exit
diff --git a/src/vs/workbench/node/extensionHostProcess.ts b/src/vs/workbench/node/extensionHostProcess.ts
@@ -17,6 +17,11 @@ interface IRendererConnection {
 	initData: IInitData;
 }
 
+/**
+ * Flag set when in shutdown phase to avoid communicating to the main process.
+ */
+let isTerminating = false;
+
 // This calls exit directly in case the initialization is not finished and we need to exit
 // Otherwise, if initialization completed we go to extensionHostMain.terminate()
 let onTerminate = function () {
@@ -36,13 +41,18 @@ function connectToRenderer(): TPromise<IRendererConnection> {
 			let msg = marshalling.parse(raw);
 
 			const remoteCom = createIPC(data => {
+				// Needed to avoid EPIPE errors in process.send below when a channel is closed
+				if (isTerminating === true) {
+					return;
+				}
 				queuedSender.send(data);
 				stats.push(data.length);
 			});
 
 			// Listen to all other messages
 			process.on('message', (msg) => {
 				if (msg.type === '__$terminate') {
+					isTerminating = true;
 					onTerminate();
 					return;
 				}
