Skip to content

Commit b02307e

Browse files
aeschliaeschli
committed
[themes][semantic] default themes: new constant color. Fixes microsoft#95346 
1 parent d1011e2 commit b02307e

5 files changed

Lines changed: 38 additions & 18 deletions

File tree

‎extensions/ruby/test/colorize-results/test_rb.json‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -432,8 +432,8 @@
432432
"c": "Models",
433433
"t": "source.ruby variable.other.constant.ruby",
434434
"r": {
435-
"dark_plus": "variable: #9CDCFE",
436-
"light_plus": "variable: #001080",
435+
"dark_plus": "variable.other.constant: #D4D4D4",
436+
"light_plus": "variable.other.constant: #000000",
437437
"dark_vs": "default: #D4D4D4",
438438
"light_vs": "default: #000000",
439439
"hc_black": "variable: #9CDCFE"
@@ -476,8 +476,8 @@
476476
"c": "MsRestAzure",
477477
"t": "source.ruby variable.other.constant.ruby",
478478
"r": {
479-
"dark_plus": "variable: #9CDCFE",
480-
"light_plus": "variable: #001080",
479+
"dark_plus": "variable.other.constant: #D4D4D4",
480+
"light_plus": "variable.other.constant: #000000",
481481
"dark_vs": "default: #D4D4D4",
482482
"light_vs": "default: #000000",
483483
"hc_black": "variable: #9CDCFE"
@@ -1191,8 +1191,8 @@
11911191
"c": "ArgumentError",
11921192
"t": "source.ruby variable.other.constant.ruby",
11931193
"r": {
1194-
"dark_plus": "variable: #9CDCFE",
1195-
"light_plus": "variable: #001080",
1194+
"dark_plus": "variable.other.constant: #D4D4D4",
1195+
"light_plus": "variable.other.constant: #000000",
11961196
"dark_vs": "default: #D4D4D4",
11971197
"light_vs": "default: #000000",
11981198
"hc_black": "variable: #9CDCFE"
@@ -1345,8 +1345,8 @@
13451345
"c": "ArgumentError",
13461346
"t": "source.ruby variable.other.constant.ruby",
13471347
"r": {
1348-
"dark_plus": "variable: #9CDCFE",
1349-
"light_plus": "variable: #001080",
1348+
"dark_plus": "variable.other.constant: #D4D4D4",
1349+
"light_plus": "variable.other.constant: #000000",
13501350
"dark_vs": "default: #D4D4D4",
13511351
"light_vs": "default: #000000",
13521352
"hc_black": "variable: #9CDCFE"
@@ -1499,8 +1499,8 @@
14991499
"c": "ServiceClientCredentials",
15001500
"t": "source.ruby variable.other.constant.ruby",
15011501
"r": {
1502-
"dark_plus": "variable: #9CDCFE",
1503-
"light_plus": "variable: #001080",
1502+
"dark_plus": "variable.other.constant: #D4D4D4",
1503+
"light_plus": "variable.other.constant: #000000",
15041504
"dark_vs": "default: #D4D4D4",
15051505
"light_vs": "default: #000000",
15061506
"hc_black": "variable: #9CDCFE"
@@ -2269,8 +2269,8 @@
22692269
"c": "MAVERICKS_PKG_PATH",
22702270
"t": "source.ruby string.interpolated.ruby meta.embedded.line.ruby source.ruby variable.other.constant.ruby",
22712271
"r": {
2272-
"dark_plus": "variable: #9CDCFE",
2273-
"light_plus": "variable: #001080",
2272+
"dark_plus": "variable.other.constant: #D4D4D4",
2273+
"light_plus": "variable.other.constant: #000000",
22742274
"dark_vs": "meta.embedded: #D4D4D4",
22752275
"light_vs": "meta.embedded: #000000",
22762276
"hc_black": "variable: #9CDCFE"
@@ -2837,4 +2837,4 @@
28372837
"hc_black": "keyword.control: #C586C0"
28382838
}
28392839
}
2840-
]
2840+
]

‎extensions/theme-defaults/themes/dark_plus.json‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,16 @@
9797
"foreground": "#9CDCFE"
9898
}
9999
},
100+
{
101+
"name": "Constants and enums",
102+
"scope": [
103+
"variable.other.constant",
104+
"variable.other.enummember"
105+
],
106+
"settings": {
107+
"foreground": "#D4D4D4",
108+
}
109+
},
100110
{
101111
"name": "Object keys, TS grammar specific",
102112
"scope": [

‎extensions/theme-defaults/themes/light_plus.json‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,16 @@
9797
"foreground": "#001080"
9898
}
9999
},
100+
{
101+
"name": "Constants and enums",
102+
"scope": [
103+
"variable.other.constant",
104+
"variable.other.enummember"
105+
],
106+
"settings": {
107+
"foreground": "#000000",
108+
}
109+
},
100110
{
101111
"name": "Object keys, TS grammar specific",
102112
"scope": [

‎extensions/typescript-basics/test/colorize-results/test-issue11_ts.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2962,8 +2962,8 @@
29622962
"c": "t",
29632963
"t": "source.ts meta.var.expr.ts meta.var-single-variable.expr.ts meta.definition.variable.ts variable.other.constant.ts",
29642964
"r": {
2965-
"dark_plus": "variable: #9CDCFE",
2966-
"light_plus": "variable: #001080",
2965+
"dark_plus": "variable.other.constant: #D4D4D4",
2966+
"light_plus": "variable.other.constant: #000000",
29672967
"dark_vs": "default: #D4D4D4",
29682968
"light_vs": "default: #000000",
29692969
"hc_black": "variable: #9CDCFE"
@@ -3398,4 +3398,4 @@
33983398
"hc_black": "default: #FFFFFF"
33993399
}
34003400
}
3401-
]
3401+
]

‎extensions/typescript-basics/test/colorize-results/test-issue5431_ts.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,8 @@
190190
"c": "timeRange",
191191
"t": "source.ts meta.function.ts meta.block.ts meta.var.expr.ts meta.var-single-variable.expr.ts meta.definition.variable.ts variable.other.constant.ts",
192192
"r": {
193-
"dark_plus": "variable: #9CDCFE",
194-
"light_plus": "variable: #001080",
193+
"dark_plus": "variable.other.constant: #D4D4D4",
194+
"light_plus": "variable.other.constant: #000000",
195195
"dark_vs": "default: #D4D4D4",
196196
"light_vs": "default: #000000",
197197
"hc_black": "variable: #9CDCFE"

0 commit comments

Comments
 (0)