Skip to content

Commit af056cd

Browse files
committed
Remove resolved TODOs
1 parent 7ad78e6 commit af056cd

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

src/vs/workbench/contrib/terminal/node/terminalProcess.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,19 +78,13 @@ export class TerminalProcess extends Disposable implements ITerminalChildProcess
7878
const results = await Promise.all([this._validateCwd(), this._validateExecutable()]);
7979
const firstError = results.find(r => r !== undefined);
8080
if (firstError) {
81-
// TODO: Anything else we need to do here to tear down the terminal instance?
82-
// this._processStartupComplete = Promise.resolve(undefined);
83-
// this._onProcessExit.fire(0);
84-
8581
return firstError;
8682
}
8783

8884
try {
8985
this.setupPtyProcess(this._shellLaunchConfig, this._ptyOptions);
9086
return undefined;
9187
} catch (err) {
92-
// TODO: Anything else we need to do here to tear down the terminal instance?
93-
// A native exception occurred
9488
this._logService.trace('IPty#spawn native exception', err);
9589
return { message: `A native exception occurred during launch (${err.message})` };
9690
}

0 commit comments

Comments
 (0)