Merge pull request microsoft#62283 from xfix/patch-1

sandy081 · web-flow · commit aee5ffa4e356 · 2018-11-01T10:41:45.000+01:00
Remove useless assignment of a promise
diff --git a/src/vs/workbench/parts/output/electron-browser/outputServices.ts b/src/vs/workbench/parts/output/electron-browser/outputServices.ts
@@ -492,7 +492,7 @@ export class OutputService extends Disposable implements IOutputService, ITextMo
 		}
 
 		this.activeChannel = channel;
-		let promise: TPromise<void> = TPromise.as(null);
+		let promise: TPromise<void>;
 		if (this.isPanelShown()) {
 			promise = this.doShowChannel(channel, preserveFocus);
 		} else {

Original file line number	Diff line number	Diff line change
`@@ -492,7 +492,7 @@ export class OutputService extends Disposable implements IOutputService, ITextMo`
`492`	`492`	`}`
`493`	`493`
`494`	`494`	`this.activeChannel = channel;`
`495`		`- let promise: TPromise<void> = TPromise.as(null);`
	`495`	`+ let promise: TPromise<void>;`
`496`	`496`	`if (this.isPanelShown()) {`
`497`	`497`	`promise = this.doShowChannel(channel, preserveFocus);`
`498`	`498`	`} else {`