Do not show option to sign into GitHub when already signed in for preferences sync, fixes microsoft#97735

Rachel Macfarlane · Rachel Macfarlane · commit ae684437a36f · 2020-06-01T10:25:21.000-07:00
diff --git a/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts b/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts
@@ -365,8 +365,11 @@ export class UserDataSyncWorkbenchService extends Disposable implements IUserDat
 
 		// Account proviers
 		for (const authenticationProvider of this.authenticationProviders) {
-			const providerName = this.authenticationService.getDisplayName(authenticationProvider.id);
-			quickPickItems.push({ label: localize('sign in using account', "Sign in with {0}", providerName), authenticationProvider });
+			const signedInForProvider = this.all.some(account => account.authenticationProviderId === authenticationProvider.id);
+			if (!signedInForProvider || this.authenticationService.supportsMultipleAccounts(authenticationProvider.id)) {
+				const providerName = this.authenticationService.getDisplayName(authenticationProvider.id);
+				quickPickItems.push({ label: localize('sign in using account', "Sign in with {0}", providerName), authenticationProvider });
+			}
 		}
 
 		return quickPickItems;
