Skip to content

Commit ae1670d

Browse files
committed
Disable terminal tests in remote
Too flaky they're not useful. See microsoft#96057
1 parent 797c86f commit ae1670d

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,10 @@
66
import { window, Pseudoterminal, EventEmitter, TerminalDimensions, workspace, ConfigurationTarget, Disposable, UIKind, env, EnvironmentVariableMutatorType, EnvironmentVariableMutator } from 'vscode';
77
import { doesNotThrow, equal, ok, deepEqual, throws } from 'assert';
88

9-
// TODO@Daniel flaky tests (https://github.com/microsoft/vscode/issues/92826)
10-
((env.uiKind === UIKind.Web) ? suite.skip : suite)('vscode API - terminal', () => {
9+
// Disable terminal tests:
10+
// - Web https://github.com/microsoft/vscode/issues/92826
11+
// - Remote https://github.com/microsoft/vscode/issues/96057
12+
((env.uiKind === UIKind.Web || typeof env.remoteName !== 'undefined') ? suite.skip : suite)('vscode API - terminal', () => {
1113
suiteSetup(async () => {
1214
const config = workspace.getConfiguration('terminal.integrated');
1315
// Disable conpty in integration tests because of https://github.com/microsoft/vscode/issues/76548

0 commit comments

Comments
 (0)