enable/disable deprecated diagnostics in core instead of requiring each diagnostic provider do so

mjbvz · mjbvz · commit adb27e5fd0bd · 2020-06-22T15:21:15.000-07:00
diff --git a/extensions/typescript-language-features/src/languageProvider.ts b/extensions/typescript-language-features/src/languageProvider.ts
@@ -127,6 +127,7 @@ export default class LanguageProvider extends Disposable {
 		const reportUnnecessary = config.get<boolean>('showUnused', true);
 		const reportDeprecated = config.get<boolean>('showDeprecated', true);
 		this.client.diagnosticsManager.updateDiagnostics(file, this._diagnosticLanguage, diagnosticsKind, diagnostics.filter(diag => {
+			// Don't both reporting diagnostics we know will not be rendered
 			if (!reportUnnecessary) {
 				if (diag.reportUnnecessary && diag.severity === vscode.DiagnosticSeverity.Hint) {
 					return false;
diff --git a/src/vs/editor/browser/widget/codeEditorWidget.ts b/src/vs/editor/browser/widget/codeEditorWidget.ts
@@ -2011,5 +2011,5 @@ registerThemingParticipant((theme, collector) => {
 	}
 
 	const deprecatedForeground = theme.getColor(editorForeground) || 'inherit';
-	collector.addRule(`.monaco-editor .${ClassName.EditorDeprecatedInlineDecoration} { text-decoration: line-through; text-decoration-color: ${deprecatedForeground}}`);
+	collector.addRule(`.monaco-editor.showDeprecated .${ClassName.EditorDeprecatedInlineDecoration} { text-decoration: line-through; text-decoration-color: ${deprecatedForeground}}`);
 });
diff --git a/src/vs/editor/common/config/editorOptions.ts b/src/vs/editor/common/config/editorOptions.ts
@@ -1232,6 +1232,10 @@ class EditorClassName extends ComputedEditorOption<EditorOption.editorClassName,
 		if (options.get(EditorOption.showUnused)) {
 			className += ' showUnused';
 		}
+
+		if (options.get(EditorOption.showDeprecated)) {
+			className += ' showDeprecated';
+		}
 		return className;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -2011,5 +2011,5 @@ registerThemingParticipant((theme, collector) => {`
`2011`	`2011`	`}`
`2012`	`2012`
`2013`	`2013`	`const deprecatedForeground = theme.getColor(editorForeground) \|\| 'inherit';`
`2014`		- collector.addRule(`.monaco-editor .${ClassName.EditorDeprecatedInlineDecoration} { text-decoration: line-through; text-decoration-color: ${deprecatedForeground}}`);
	`2014`	+ collector.addRule(`.monaco-editor.showDeprecated .${ClassName.EditorDeprecatedInlineDecoration} { text-decoration: line-through; text-decoration-color: ${deprecatedForeground}}`);
`2015`	`2015`	`});`
Original file line number	Diff line number	Diff line change
`@@ -1232,6 +1232,10 @@ class EditorClassName extends ComputedEditorOption<EditorOption.editorClassName,`
`1232`	`1232`	`if (options.get(EditorOption.showUnused)) {`
`1233`	`1233`	`className += ' showUnused';`
`1234`	`1234`	`}`
	`1235`	`+`
	`1236`	`+ if (options.get(EditorOption.showDeprecated)) {`
	`1237`	`+ className += ' showDeprecated';`
	`1238`	`+ }`
`1235`	`1239`	`return className;`
`1236`	`1240`	`}`
`1237`	`1241`	`}`