Skip to content

Commit acf2dff

Browse files
committed
1 parent 77d2469 commit acf2dff

2 files changed

Lines changed: 32 additions & 0 deletions

File tree

‎src/vs/base/browser/ui/tree/indexTreeModel.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -442,6 +442,7 @@ export class IndexTreeModel<T extends Exclude<any, undefined>, TFilterData = voi
442442

443443
if (visibility === TreeVisibility.Hidden) {
444444
node.visible = false;
445+
node.renderNodeCount = 0;
445446
return false;
446447
}
447448

‎src/vs/base/test/browser/ui/tree/indexTreeModel.test.ts‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -724,4 +724,35 @@ suite('IndexTreeModel', function () {
724724
model.refilter();
725725
assert.deepEqual(toArray(list), ['platinum']);
726726
});
727+
728+
test('explicit hidden nodes should have renderNodeCount == 0, issue #83211', function () {
729+
const list: ITreeNode<string>[] = [];
730+
let query = new RegExp('');
731+
const filter = new class implements ITreeFilter<string> {
732+
filter(element: string): boolean {
733+
return query.test(element);
734+
}
735+
};
736+
737+
const model = new IndexTreeModel<string>('test', toSpliceable(list), 'root', { filter });
738+
739+
model.splice([0], 0, [
740+
{ element: 'a', children: [{ element: 'aa' }] },
741+
{ element: 'b', children: [{ element: 'bb' }] }
742+
]);
743+
744+
assert.deepEqual(toArray(list), ['a', 'aa', 'b', 'bb']);
745+
assert.deepEqual(model.getListIndex([0]), 0);
746+
assert.deepEqual(model.getListIndex([0, 0]), 1);
747+
assert.deepEqual(model.getListIndex([1]), 2);
748+
assert.deepEqual(model.getListIndex([1, 0]), 3);
749+
750+
query = /b/;
751+
model.refilter();
752+
assert.deepEqual(toArray(list), ['b', 'bb']);
753+
assert.deepEqual(model.getListIndex([0]), -1);
754+
assert.deepEqual(model.getListIndex([0, 0]), -1);
755+
assert.deepEqual(model.getListIndex([1]), 0);
756+
assert.deepEqual(model.getListIndex([1, 0]), 1);
757+
});
727758
});

0 commit comments

Comments
 (0)