Don't show errors for shell provided tasks

alexr00 · alexr00 · commit ace2f9570cef · 2020-05-07T16:10:30.000+02:00
Related to microsoft/vscode-cpptools#5388
diff --git a/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts b/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts
@@ -1579,7 +1579,9 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
 								for (const task of taskSet.tasks) {
 									if (task.type !== this._providerTypes.get(handle)) {
 										this._outputChannel.append(nls.localize('unexpectedTaskType', "The task provider for \"{0}\" tasks unexpectedly provided a task of type \"{1}\".\n", this._providerTypes.get(handle), task.type));
-										this.showOutput();
+										if ((task.type !== 'shell') && (task.type !== 'process')) {
+											this.showOutput();
+										}
 										break;
 									}
 								}

Original file line number	Diff line number	Diff line change
`@@ -1579,7 +1579,9 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer`
`1579`	`1579`	`for (const task of taskSet.tasks) {`
`1580`	`1580`	`if (task.type !== this._providerTypes.get(handle)) {`
`1581`	`1581`	`this._outputChannel.append(nls.localize('unexpectedTaskType', "The task provider for \"{0}\" tasks unexpectedly provided a task of type \"{1}\".\n", this._providerTypes.get(handle), task.type));`
`1582`		`- this.showOutput();`
	`1582`	`+ if ((task.type !== 'shell') && (task.type !== 'process')) {`
	`1583`	`+ this.showOutput();`
	`1584`	`+ }`
`1583`	`1585`	`break;`
`1584`	`1586`	`}`
`1585`	`1587`	`}`